From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64903C282C2 for ; Thu, 7 Feb 2019 17:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21E192083B for ; Thu, 7 Feb 2019 17:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="boHnnQZ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbfBGRqz (ORCPT ); Thu, 7 Feb 2019 12:46:55 -0500 Received: from mx2.ucr.edu ([138.23.62.3]:18734 "EHLO mx2.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfBGRqz (ORCPT ); Thu, 7 Feb 2019 12:46:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1549561614; x=1581097614; h=from:to:cc:subject:date:message-id; bh=wImntgiBJtk3wwGZmT6fv88DkNLi+LVBqQWMeTeg6K4=; b=boHnnQZ1CX5hTk/vdNMyCWn5SZufxJAYVcZ2bsH7eSo4V2lINhuvR/zv BRiUvPNKofH2JXej1DlSQIOqy3KNuTyE8lpC1vWG47HzWHr9RkIqHp1my 685g4yigctcPyaAw9fZ1VjWMiTEmMk6/HJyJsfp20aoSTLdt6ikons3ZV Y0/0hMLfj5eJa7Kl7Z+prx+K4xeYPYg1GwWT2OMUI3XhXJ+6f4lO6+0MD oBH8Q6bTlMysckqWONldxQpz1dh/SGOIZlOlE7ejf4Ha54me48aFGSFbE kujEdEgmcnhhQOrcPGM84lejoFpqXijwHdx04zV6PqSgtg2aE0IpzE1dK Q==; IronPort-PHdr: =?us-ascii?q?9a23=3AgAtEeRXskcj3I/czjdqfcwK6/RjV8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYYxOHt8tkgFKBZ4jH8fUM07OQ7/iwHzRYqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRo?= =?us-ascii?q?LerpBIHSk9631+ev8JHPfglEnjWwba9xIRmssQndqtQdjJd/JKo21hbHuGZDdf?= =?us-ascii?q?5MxWNvK1KTnhL86dm18ZV+7SleuO8v+tBZX6nicKs2UbJXDDI9M2Ao/8LrrgXM?= =?us-ascii?q?TRGO5nQHTGoblAdDDhXf4xH7WpfxtTb6tvZ41SKHM8D6Uaw4VDK/5KpwVhTmlD?= =?us-ascii?q?kIOCI48GHPi8x/kqRboA66pxdix4LYeZyZOOZicq/Ye94aQGtBXt1KVyxABIO8?= =?us-ascii?q?YJYEAfQYM+1FoYn9pkUBrR+jCgKxAO/ixCNEinrw0KYn0eouDBvG0RQgEdwQrX?= =?us-ascii?q?raotb7OqAJXOyp0KXF1ynPYulK1Tvh7oXDbxAvoeuLXbJ1acfey0gvFgLFjlWN?= =?us-ascii?q?rozuIjSY1+QMsmib9eVgVP6jh3Ippgxqvzig2t0shpPXiY0I11DJ7CN0y5s2K9?= =?us-ascii?q?2gUEN3f8KoHZ9KuyyZN4Z6WN0uT3xotSog1LEKpYK3cDAXxJkmwxPTceKLfoaI?= =?us-ascii?q?7x75SuqcIC10iXBqdb+5mh2861KvyvfmWcmxyFtKqy1FncTSuX0VzBzT79SHSu?= =?us-ascii?q?N6/ke8xTaDzwDT5f9AIUAzjafbLoQuwr80lpYKqUTDETL6lFz4jKOIakko5vKk?= =?us-ascii?q?6+vgYrXhqZ+cM5F7hhviPaQpn8yzGeU4Mg4QUGiH4emwyqHv8EnjTLhJjvA6iL?= =?us-ascii?q?fVvI3aKMgBuKK1HxNZ3p4m6xmlDjem1NoYnWMALFJAYB+Gj4noO1HUL/D5Efuz?= =?us-ascii?q?n1qhnSx2x//aJL3tGIvCIWXekLv5Z7Zy91ZcyBYvzdBY/59UDK8OIO7uVUDvqt?= =?us-ascii?q?zVFQE5MwOqzOb9Etl91Z0RWXiJAqCHNKPeq1iI5vggI7rESpUSvWPMKuol+vmm?= =?us-ascii?q?2W4rmVYcJfHy9YYccja1EukwcBbRWmblntpUSTRChQE5VuG/zQLaXA=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2CmAwCnblxcgMjXVdFkHAEBAQQBAQcEA?= =?us-ascii?q?QGBZYM8Sg+MfIsQUgaKfm2FWYJzhwoBCgEBLIRAgyoiSgEDAQECAQMBEwEBCQ0?= =?us-ascii?q?JCBsMMYI6KYJfNlKBFQEFATVbgkkBgXQNoVg8jBcziFkBB4FLCQEIh3CEQYEPg?= =?us-ascii?q?QeDboR/g1SCQwKBLAEBAYpQhTyRVAEGAgGBZYFDjxElgW2BSocBOIdkAS2bTwI?= =?us-ascii?q?EAgQFAgUPIYMzTSWBbAqBRIJSjiweM4EHiyaCTQE?= X-IPAS-Result: =?us-ascii?q?A2CmAwCnblxcgMjXVdFkHAEBAQQBAQcEAQGBZYM8Sg+MfIs?= =?us-ascii?q?QUgaKfm2FWYJzhwoBCgEBLIRAgyoiSgEDAQECAQMBEwEBCQ0JCBsMMYI6KYJfN?= =?us-ascii?q?lKBFQEFATVbgkkBgXQNoVg8jBcziFkBB4FLCQEIh3CEQYEPgQeDboR/g1SCQwK?= =?us-ascii?q?BLAEBAYpQhTyRVAEGAgGBZYFDjxElgW2BSocBOIdkAS2bTwIEAgQFAgUPIYMzT?= =?us-ascii?q?SWBbAqBRIJSjiweM4EHiyaCTQE?= X-IronPort-AV: E=Sophos;i="5.58,345,1544515200"; d="scan'208";a="1055034898" Received: from mail-pg1-f200.google.com ([209.85.215.200]) by smtp2.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 07 Feb 2019 09:46:38 -0800 Received: by mail-pg1-f200.google.com with SMTP id t26so381085pgu.18 for ; Thu, 07 Feb 2019 09:46:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2tzpVyPYpfdzliPB1oyDkazyBfCrViS9BIM/UOQo4PI=; b=CtDDHUMLZtF/orhK31b6/APlXKMryqZnEzYmEKce/BHebhWOxJ97PiqXr/La/PlyvU YzdmSSQyi8ij63zxTCf8EsyHi4hLe7TyovjnYldp1/79g3wLMO9ql9uMK/POGGb4PaVY za2jz1g99bHO6Tf6uuepoNFbMT03EL5r730+DcVMk9CA7bhX4w9LgUXsrNEHJ2/fcQWL kB95/MHZ1doru4b8Ia3i015Z5e5lsFRJ37woKnItPrQOACG6JWEjAjFNyPP4v4gkR+nD sEKweV1fK8PAP5jKxeq6LJa3YDgpD9qFBJaoq4a1oe+UjsA09UBgm592zRxcmU+VCxcl cMIw== X-Gm-Message-State: AHQUAuZXBZtLDHnRdQn3U/ZL6eWqkueCKkbH7W33t8LwCjQwh75mIRl8 g9ZlZI4g1tHVkq5P2yT166SS8zXRJNbImvlcxubhtgUxU1vujaCSQFE2jf0JomHnn2/1nUtVvjl gbdjmsKl2OYwrqrGSsw== X-Received: by 2002:a63:da14:: with SMTP id c20mr15338847pgh.233.1549561597764; Thu, 07 Feb 2019 09:46:37 -0800 (PST) X-Google-Smtp-Source: AHgI3IayrGVGwQ3ZjOg/wOj9tm31uHR4CdpsjffL6HoAIgRqtFTZ12maLg7c1SCwb6lANot4erlZ3A== X-Received: by 2002:a63:da14:: with SMTP id c20mr15338773pgh.233.1549561597020; Thu, 07 Feb 2019 09:46:37 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id m67sm14007791pfm.73.2019.02.07.09.46.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 09:46:36 -0800 (PST) From: Yizhuo Cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo , Giuseppe Cavallaro , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Date: Thu, 7 Feb 2019 09:46:23 -0800 Message-Id: <20190207174623.16712-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In function sun8i_dwmac_set_syscon(), local variable "val" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used directly in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 39c2122a4f26..50cfd6d83052 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -641,7 +641,12 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) int ret; u32 reg, val; - regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); + if (ret) { + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); + return ret; + } + reg = gmac->variant->default_syscon_value; if (reg != val) dev_warn(priv->device, -- 2.17.1