From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405D2C282C4 for ; Thu, 7 Feb 2019 21:38:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C2E12080A for ; Thu, 7 Feb 2019 21:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GWcBqi87" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfBGViM (ORCPT ); Thu, 7 Feb 2019 16:38:12 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37416 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726512AbfBGViM (ORCPT ); Thu, 7 Feb 2019 16:38:12 -0500 Received: by mail-wr1-f65.google.com with SMTP id c8so1478665wrs.4 for ; Thu, 07 Feb 2019 13:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WnJSVzcBaR2Ml0fQy+xhdUpmMXa3f/LpsMqUegcthm8=; b=GWcBqi87bJaH68PfkjvucJavjiroWvmVTdTkCrdKz85n+oB4G3Mo5bLJxKTSU29bmN SKspvjMK5CJhzq2WQ6HA10buFgIYH1WhXTfxTVnOZOui4KrtwsdwUPzJwOySJAYUCxbm rS6SX1nxTcjOwqwtPrC6lvM49KI6a9qCk+z8hibhK6QGcK+A+TKk6uTh/RT6D5N0zhSL GNMOh9XEqbyd8OgM7iWk78ZV0T8e++LlcnTtoJlJUu1xrZqlRrP9oySJWTRN1vJS7ZOE slIeeK5c8c8oh5jwYUAu8H88I2PJhqaOCkwEmaIpN7E8ehyA7T6eekcs4b/1Dob/CR5/ 42UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WnJSVzcBaR2Ml0fQy+xhdUpmMXa3f/LpsMqUegcthm8=; b=CHWVK1MYVyw18nb+JQEw9YuFvHkUs89IT2EfpyCsd6oaE05SzNxJuyDl7pWsEKy8B/ lahCH/qG6dR5Cr5AggT3nmOpnBg9r1/rmyrEgvmLofdqMeJcOodOAEpHOrOD6TqgeBlb 7IkW2utddIw041bq24YSt/skha2gzKC35ZViQF9cXjeiU2uJ/GpkuqpZkX54Qi/9fYOf SPvLD94ANrGTZSC+IyKFOO9wCuDJVHxhWdA0Ev1oPgBN51N4WE3R5iGobZhiTmaMK6rB /z/lvYM7yRSUPgJ4NSYgiR8ozACHmakNYiyuDs35R4oGoPdUsBa9ecxpMN7BdGmWEt0W R7rQ== X-Gm-Message-State: AHQUAuby6N0ZWUNveSeeM95Z9c0wsFuwqlYNFWNlBvR1fDDSGyoTb6Mg nYmoGkxu0SqR++g3EvgsjYdDBA== X-Google-Smtp-Source: AHgI3IYRUTO4GPpB9PhrCrsk3FAnMM/rIcMd8TfhXXXnNTziuPlfZ5c6hL9Gzdx6MBZXmV1hxmQFhg== X-Received: by 2002:a5d:4a4b:: with SMTP id v11mr2431231wrs.186.1549575489954; Thu, 07 Feb 2019 13:38:09 -0800 (PST) Received: from Iliass-MBP.lan (ppp-94-65-225-153.home.otenet.gr. [94.65.225.153]) by smtp.gmail.com with ESMTPSA id t12sm190819wra.63.2019.02.07.13.38.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 13:38:09 -0800 (PST) Date: Thu, 7 Feb 2019 23:37:58 +0200 From: Ilias Apalodimas To: David Miller Cc: willy@infradead.org, brouer@redhat.com, tariqt@mellanox.com, toke@redhat.com, netdev@vger.kernel.org, mgorman@techsingularity.net, linux-mm@kvack.org Subject: Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t Message-ID: <20190207213758.GA10662@Iliass-MBP.lan> References: <1549550196-25581-1-git-send-email-ilias.apalodimas@linaro.org> <20190207150745.GW21860@bombadil.infradead.org> <20190207152034.GA3295@apalos> <20190207.132519.1698007650891404763.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190207.132519.1698007650891404763.davem@davemloft.net> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, On Thu, Feb 07, 2019 at 01:25I:19PM -0800, David Miller wrote: > From: Ilias Apalodimas > Date: Thu, 7 Feb 2019 17:20:34 +0200 > > > Well updating struct page is the final goal, hence the comment. I am mostly > > looking for opinions here since we are trying to store dma addresses which are > > irrelevant to pages. Having dma_addr_t definitions in mm-related headers is a > > bit controversial isn't it ? If we can add that, then yes the code would look > > better > > I fundamentally disagree. > > One of the core operations performed on a page is mapping it so that a device > and use it. > > Why have ancillary data structure support for this all over the place, rather > than in the common spot which is the page. You are right on that. Moreover the intention of this change is to facilitate the page recycling patches we proposed with Jesper. In that context we do need the dma mapping information in a common spot since we'll need to access it from drivers, networking code etc. The struct page *is* the best place for that. > > A page really is not just a 'mm' structure, it is a system structure. Well if you put it that way i completely agree (also it makes our life a *lot* easier :)) Thanks /Ilias