From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A22C282C4 for ; Thu, 7 Feb 2019 21:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A2F52175B for ; Thu, 7 Feb 2019 21:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Tq8oB44z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfBGVmn (ORCPT ); Thu, 7 Feb 2019 16:42:43 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:32931 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726512AbfBGVmn (ORCPT ); Thu, 7 Feb 2019 16:42:43 -0500 Received: by mail-wr1-f65.google.com with SMTP id a16so1524764wrv.0 for ; Thu, 07 Feb 2019 13:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qx+TUyFynWwI5KhCI9PcXSu3iAJe4wwFjtiyfwFfwT4=; b=Tq8oB44z+mcyoIvV/vzLjRbfSxMWsokLRaWhIDe3CysWa4gG02k90luF5eHMa5ReB7 M8HYiEKRTt8OLJ353ZFTZw7TMTL6kTwa4aMJr9LvhZBG5tvh/eIgYWPdU3Xx/roPHxGZ AMLRlOxG12GCedyD5l36EbMs2XhEnXFLTioUZE1wHZsiMfWBHN8uOv9KKDD5xESJFgY3 Kkk0/QBj0JEYbmdsTNwxiYz07T/voemOQGlRnCoC91rlllYwWxojD+oapJ6PRpgHZenV MWtHKjlmHfQfb0hTxjQOdt1YiIJq1p80VOe7nYHkFQxQhz+6njbrrvQrDzKy8l7il5+b he+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qx+TUyFynWwI5KhCI9PcXSu3iAJe4wwFjtiyfwFfwT4=; b=BGD0FWpdAcO7rDQqP0qYvNGBlHDzK10OMED3HVF//2XiMkBtWpaWZuy49IKbrxPFPc VRTYGzbg1+D6Ysfpa32WzgzzaYf/3EW2kENMgNCBVJXKnZ6LpDDaN+wd5A6XrPCMBjpa mn+1KsQhzmY+u62TzyeiDghMqF/rHeMJ01TPHfxsXXJytlILLfMghsq1NiEIqH/miEku wW3bvtKYKtFeznYBvYmaMKV71R4li+gZcknsKwTbyOEaAci5YLut+44IhhEyovlK678b FweRO1xXnBu1oTrPKpPoNbGalZjZgVRgeaEgzft4pmxZQW/rYh2Oiw4UNs8tjORCioWJ msbQ== X-Gm-Message-State: AHQUAua53uifT9NSHdoTKhC1O5f6+j1YZg6JTHl5pVYhULNz5PJOUttO xABkOI9zJ4R3RZ2Jtm0y5v7KVw== X-Google-Smtp-Source: AHgI3Ia4FJgVQ19IPgjc0GgQ156H2vm0SwFc9gOm/r8e+JrKyKQMu7W2+wrRk9kQHELcBaYYXDuQfA== X-Received: by 2002:adf:f390:: with SMTP id m16mr13382272wro.71.1549575761046; Thu, 07 Feb 2019 13:42:41 -0800 (PST) Received: from Iliass-MBP.lan (ppp-94-65-225-153.home.otenet.gr. [94.65.225.153]) by smtp.gmail.com with ESMTPSA id y8sm700573wmg.13.2019.02.07.13.42.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 13:42:40 -0800 (PST) Date: Thu, 7 Feb 2019 23:42:37 +0200 From: Ilias Apalodimas To: Matthew Wilcox Cc: David Miller , brouer@redhat.com, tariqt@mellanox.com, toke@redhat.com, netdev@vger.kernel.org, mgorman@techsingularity.net, linux-mm@kvack.org Subject: Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t Message-ID: <20190207214237.GA10676@Iliass-MBP.lan> References: <1549550196-25581-1-git-send-email-ilias.apalodimas@linaro.org> <20190207150745.GW21860@bombadil.infradead.org> <20190207152034.GA3295@apalos> <20190207.132519.1698007650891404763.davem@davemloft.net> <20190207213400.GA21860@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190207213400.GA21860@bombadil.infradead.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Matthew, On Thu, Feb 07, 2019 at 01:34:00PM -0800, Matthew Wilcox wrote: > On Thu, Feb 07, 2019 at 01:25:19PM -0800, David Miller wrote: > > From: Ilias Apalodimas > > Date: Thu, 7 Feb 2019 17:20:34 +0200 > > > > > Well updating struct page is the final goal, hence the comment. I am mostly > > > looking for opinions here since we are trying to store dma addresses which are > > > irrelevant to pages. Having dma_addr_t definitions in mm-related headers is a > > > bit controversial isn't it ? If we can add that, then yes the code would look > > > better > > > > I fundamentally disagree. > > > > One of the core operations performed on a page is mapping it so that a device > > and use it. > > > > Why have ancillary data structure support for this all over the place, rather > > than in the common spot which is the page. > > > > A page really is not just a 'mm' structure, it is a system structure. > > +1 > > The fundamental point of computing is to do I/O. Ok, great that should sort it out then. I'll use your proposal and base the patch on that. Thanks for taking the time with this /Ilias