From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ariel Elior <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [EXT] Re: [PATCH net-next 0/2] qed*: SmartAN query support
Date: Fri, 8 Feb 2019 08:04:29 -0800 [thread overview]
Message-ID: <20190208080429.0411ea05@cakuba.netronome.com> (raw)
In-Reply-To: <MWHPR18MB12642183A28EA8D162CAC9D3D3690@MWHPR18MB1264.namprd18.prod.outlook.com>
On Fri, 8 Feb 2019 11:32:14 +0000, Sudarsana Reddy Kalluru wrote:
> >On Thu, 7 Feb 2019 06:20:10 -0800, Sudarsana Reddy Kalluru wrote:
> >> SmartAN feature detects the peer/cable capabilities and establishes
> >> the link in the best possible configuration.
> >
> >It sounds familiar, I need to check with FW team, but I think we may be doing
> >a similar thing, and adding a common API rather than ethtool flag would be
> >preferable.
> >
> >Could you please share a little bit more detail? What are the configurations
> >this would choose between?
>
> Jakub,
> Following doc provides detailed information on this feature. We simply need a flag to display whether the feature is enabled in the hardware or not, hence adding it to "ethtool --show-priv-flags".
> https://www.cavium.com/Dell/Documents/Converged/TB_Establishing_Adaptive_Links_with_SmartAN_Dell.pdf
Thanks! Yes, that's exactly the same thing. In a nutshell trying
different serdes and FEC speeds. I guess I'll just put adding an API
for this down as a TODO, and add it once we have ethtool netlink. And
keep IOCTL ethtool frozen until then.
So I think the priv flag is fine for now.
next prev parent reply other threads:[~2019-02-08 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:20 [PATCH net-next 0/2] qed*: SmartAN query support Sudarsana Reddy Kalluru
2019-02-07 14:20 ` [PATCH net-next 1/2] qed: Add API for SmartAN query Sudarsana Reddy Kalluru
2019-02-07 14:20 ` [PATCH net-next 2/2] qede: Add ethtool interface " Sudarsana Reddy Kalluru
2019-02-07 19:54 ` [PATCH net-next 0/2] qed*: SmartAN query support Jakub Kicinski
2019-02-08 11:32 ` [EXT] " Sudarsana Reddy Kalluru
2019-02-08 16:04 ` Jakub Kicinski [this message]
2019-02-09 6:55 ` David Miller
2019-02-07 21:22 ` David Miller
2019-02-07 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208080429.0411ea05@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=mkalderon@marvell.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).