From: Florian Westphal <fw@strlen.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Mahesh Bandewar <maheshb@google.com>,
Florian Westphal <fw@strlen.de>, Martynas Pumputis <m@lambda.lt>
Subject: Re: [PATCH net-next] ipvlan: decouple l3s mode dependencies from other modes
Date: Fri, 8 Feb 2019 14:29:41 +0100 [thread overview]
Message-ID: <20190208132941.bmbvuqckocuyhujr@breakpoint.cc> (raw)
In-Reply-To: <20190208125531.28970-1-daniel@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> wrote:
> Right now ipvlan has a hard dependency on CONFIG_NETFILTER and
> otherwise it cannot be built. However, the only ipvlan operation
> mode that actually depends on netfilter is l3s, everything else
> is independent of it. Break this hard dependency such that users
> are able to use ipvlan l3 mode on systems where netfilter is not
> compiled in.
>
> Therefore, this adds a hidden CONFIG_IPVLAN_L3S bool which is
> defaulting to y when CONFIG_NETFILTER is set in order to retain
> existing behavior for l3s. All l3s related code is refactored
> into ipvlan_l3s.c that is compiled in when enabled.
IIRC L3S is only meaningful with netfilter anyway, so this
looks like a good thing to do.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-02-08 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 12:55 [PATCH net-next] ipvlan: decouple l3s mode dependencies from other modes Daniel Borkmann
2019-02-08 13:29 ` Florian Westphal [this message]
2019-02-08 13:39 ` Daniel Borkmann
2019-02-08 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208132941.bmbvuqckocuyhujr@breakpoint.cc \
--to=fw@strlen.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=m@lambda.lt \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).