From: David Miller <davem@davemloft.net>
To: tuba@ece.ufl.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: hso: do not unregister if not registered
Date: Sat, 09 Feb 2019 09:35:51 -0800 (PST) [thread overview]
Message-ID: <20190209.093551.1941095439637753471.davem@davemloft.net> (raw)
In-Reply-To: <89a423a522834affadda4aaf7ab4d333@exmbxprd18.ad.ufl.edu>
From: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Date: Sat, 9 Feb 2019 16:24:20 +0000
>
>
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
> Signed-off-by: Tuba Yavuz <tuba@ece.ufl.edu>
Your patch is still corrupted.
Email this patch to yourself and try to apply it to a source tree.
You will see that it won't work.
Please do not post this patch again until you have fixed this problem
and have also successfully applied a patch you have test emailed to
yourself.
Thanks.
next prev parent reply other threads:[~2019-02-09 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 16:24 [PATCH] net: hso: do not unregister if not registered Yavuz, Tuba
2019-02-09 17:35 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-06 0:40 Yavuz, Tuba
2019-02-08 23:08 ` David Miller
2019-02-09 0:02 ` Yavuz, Tuba
2019-02-09 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209.093551.1941095439637753471.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tuba@ece.ufl.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).