From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D039C282C4 for ; Sat, 9 Feb 2019 08:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6B492084D for ; Sat, 9 Feb 2019 08:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="v/HkzCOD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfBIIpL (ORCPT ); Sat, 9 Feb 2019 03:45:11 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55210 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfBIIpL (ORCPT ); Sat, 9 Feb 2019 03:45:11 -0500 Received: by mail-wm1-f67.google.com with SMTP id a62so7459461wmh.4 for ; Sat, 09 Feb 2019 00:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ch29ZC1rlYJWCFJvnaVRbZTM5e0yB7gLZ83oYPE4m+E=; b=v/HkzCODfPo+OJideobSlxnJIhu7Uqf4EjezwyTtnxFr83D87LkFpxWUC2zRV6X/Fx dNzkn6e2QMWSqGrxuYTLdAYMGAD8ISV4v4T6tBoFPeTAv1hrycElTsTEtgGEv/GEVaT0 p0FIWrdNo8+hZh282kBGFGNXYCZEgiZUDOxmuSzdPgiAihwNqZkPydayjMs4K2UKgolu 5f3IaqCDfJ+dRopyEUbrOH60+C3vJrRK3fe5en/WLnfymwoyNHLf2yU4LLaNXZvB1fY2 uqYXSWkLPKsVWWHu6Os7FgimrQnUoT/Ioy5xb9gJR3xZ9Vbz5FP+Pr3hoe30oQpBaNoK nmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ch29ZC1rlYJWCFJvnaVRbZTM5e0yB7gLZ83oYPE4m+E=; b=de3h513uBQc5R48qFcCb+DBC+LKZnNzoWZ0nQe2rf7u9R1OINXQ26XKHOcKelYj0lB HkIklL4L2c4LIkByy4NvSuhVmSw/hr7s5++psFjKywucArRuDSFGzStdaQo1olRHbbtN I06EtQvfQ4+2Bt7nXIEZzsdsMKvNl+vzaOxdLWcdxAAKq1Kq1KH7wXt3NEvOOrdDK+rq rzSBe6wN7OsW2ObKcko1T1wbzIitMJFxGvvId/cINhBNis73jnJa5G4H4R7rgs4qkHq3 7IGpvX+UpTu6O/HCZta57Afjsnom2vb2qj+PzuAqoOxuWIi95Ow69hxfbFCsRWA8055D +cCA== X-Gm-Message-State: AHQUAuaxVRZSs+BvXKbUCXpjOV2gaxQyv5Y78YVAblRzo+5643TpLHp8 FQf/kTsJ/k4hnMImEz0jKdc46A== X-Google-Smtp-Source: AHgI3IbbvqAjJ7PIpyIcrzivbB6NGwbwj3za24LCkgh64bVShnzGuG5Dhw2ArvYVfDpJAXmfuENU3g== X-Received: by 2002:a7b:c013:: with SMTP id c19mr1913520wmb.27.1549701909746; Sat, 09 Feb 2019 00:45:09 -0800 (PST) Received: from localhost (ip-94-113-219-55.net.upcbroadband.cz. [94.113.219.55]) by smtp.gmail.com with ESMTPSA id q15sm2598473wmj.46.2019.02.09.00.45.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Feb 2019 00:45:09 -0800 (PST) Date: Sat, 9 Feb 2019 09:35:57 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next 2/4] devlink: don't allocate attrs on the stack Message-ID: <20190209083557.GF2353@nanopsycho> References: <20190209031611.1102-1-jakub.kicinski@netronome.com> <20190209031611.1102-3-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190209031611.1102-3-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Feb 09, 2019 at 04:16:09AM CET, jakub.kicinski@netronome.com wrote: >Number of devlink attributes has grown over 128, causing the >following warning: > >../net/core/devlink.c: In function ‘devlink_nl_cmd_region_read_dumpit’: >../net/core/devlink.c:3740:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] > } > ^ > >Since the number of attributes is only going to grow allocate >the array dynamically. > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko