From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D99C282C4 for ; Sat, 9 Feb 2019 18:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8C90214DA for ; Sat, 9 Feb 2019 18:31:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="xVMPdRV4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbfBISbB (ORCPT ); Sat, 9 Feb 2019 13:31:01 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:33395 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727199AbfBISbB (ORCPT ); Sat, 9 Feb 2019 13:31:01 -0500 Received: by mail-wm1-f66.google.com with SMTP id h22so9988336wmb.0 for ; Sat, 09 Feb 2019 10:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yr8T0OftPvmj7cclVgXC3g3ec7i9ITG1oi95HtFGeUA=; b=xVMPdRV41wVTjgRTVgGLPvjDAodOzGZPxmufekf6OnvrgmdmsFclF/xyCjG2tBkJYz /hVX3HExy5GrGpCfWddHdCQdkGO5QHvq6oRkdfV7IZGQgecyi1bRHcaASnx7jRt41B5M 29o5V9Gapgsn3hwYq38VOzE1niEKSLf524LJEzGy8YBW/oOiqVqSl4j2NDdYKjjdiBxE 3hveg7y0y6jzYggFsgCguL3P7BGVvRBGdFV1q3eKT6aYZk7oC2MaHejbHzNf0pty0L89 9zxTxtEUeDuXZy7FB7InzivSuOcpGhLjHvaFkaKAcQf+xjDissekcWE2flouEjECH+zK 2MVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yr8T0OftPvmj7cclVgXC3g3ec7i9ITG1oi95HtFGeUA=; b=cDiSELryhNGcgWHYkXQtuxTyLJ5yFztbShiMhmDW/PDUek/O+Pk2TGcxDbxhv/XeL4 RHCG1mbgr6DAyQxxsDCECF5AIxySvakdRxHh0nDlYrop7uJ7RHtjacFWYz31pwgrbNig rpCqGYQrrV9Jd3uEMooQRSGuqQqqI6misg08vzg+ynET8/xfwls0mG6gpgU7aJOsWjjD I8lOlcZhuSQ09+yYIjSOhFYL/8pG1dVBlc0fyQ946L0fewtGq8rUa7LQ5jlW3tnk2rWP ia9xBfluDnBxf7OTDdZlPEFgEiVVkjGeNh8tau+nc4t+TxMn4KwOxQLRJdCGOWZfEo49 YAzw== X-Gm-Message-State: AHQUAubsrieWw8qi8qbgv8Cf5Sz/mf5ZS1/Gtl0SiMf0x9CinnBAfrrM l0fp2O13BCfvG6uD8Bg9ZDHoWA== X-Google-Smtp-Source: AHgI3IYCpRzH711asp/DrW+Wx2S6RJ/bEsO+I4DygtBSoz3d2mi03pBpV/vomH9F+A0Cl5mwY/2RBA== X-Received: by 2002:a5d:534e:: with SMTP id t14mr13757602wrv.328.1549737059704; Sat, 09 Feb 2019 10:30:59 -0800 (PST) Received: from localhost (ip-94-113-219-55.net.upcbroadband.cz. [94.113.219.55]) by smtp.gmail.com with ESMTPSA id n3sm6070462wmf.46.2019.02.09.10.30.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Feb 2019 10:30:59 -0800 (PST) Date: Sat, 9 Feb 2019 19:21:47 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET Message-ID: <20190209182147.GQ2353@nanopsycho> References: <20190209003248.31088-1-f.fainelli@gmail.com> <20190209003248.31088-11-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190209003248.31088-11-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Feb 09, 2019 at 01:32:42AM CET, f.fainelli@gmail.com wrote: >Following patches will change the way we communicate getting or setting Just "setting", no "getting". >a port's attribute and use a blocking notifier to perform those tasks. > >Prepare rocker to support receiving notifier events targeting >SWITCHDEV_PORT_ATTR_SET and simply translate that into the existing >rocker_port_attr_set call. > >Signed-off-by: Florian Fainelli >--- > drivers/net/ethernet/rocker/rocker_main.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > >diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c >index ff3f14504f4f..f10e4888ecff 100644 >--- a/drivers/net/ethernet/rocker/rocker_main.c >+++ b/drivers/net/ethernet/rocker/rocker_main.c >@@ -2811,6 +2811,24 @@ rocker_switchdev_port_obj_event(unsigned long event, struct net_device *netdev, > return notifier_from_errno(err); > } > >+static int >+rocker_switchdev_port_attr_event(unsigned long event, struct net_device *netdev, >+ struct switchdev_notifier_port_attr_info >+ *port_attr_info) >+{ >+ int err = -EOPNOTSUPP; >+ >+ switch (event) { >+ case SWITCHDEV_PORT_ATTR_SET: Do you expect some other event to be handled in rocker_switchdev_port_attr_event()? Because you have SWITCHDEV_PORT_ATTR_SET selected in case here and in rocker_switchdev_blocking_event. Perhaps you can rename rocker_switchdev_port_attr_event() to rocker_switchdev_port_attr_set_event() and avoid this switchcase. >+ err = rocker_port_attr_set(netdev, port_attr_info->attr, >+ port_attr_info->trans); >+ break; >+ } >+ >+ port_attr_info->handled = true; >+ return notifier_from_errno(err); >+} >+ > static int rocker_switchdev_blocking_event(struct notifier_block *unused, > unsigned long event, void *ptr) > { >@@ -2823,6 +2841,8 @@ static int rocker_switchdev_blocking_event(struct notifier_block *unused, > case SWITCHDEV_PORT_OBJ_ADD: > case SWITCHDEV_PORT_OBJ_DEL: > return rocker_switchdev_port_obj_event(event, dev, ptr); >+ case SWITCHDEV_PORT_ATTR_SET: >+ return rocker_switchdev_port_attr_event(event, dev, ptr); > } > > return NOTIFY_DONE; >-- >2.17.1 >