From: Al Viro <viro@zeniv.linux.org.uk>
To: netdev@vger.kernel.org
Cc: Solar Designer <solar@openwall.com>, David Miller <davem@davemloft.net>
Subject: [RFC] apparently bogus logics in unix_find_other() since 2002
Date: Sun, 10 Feb 2019 04:24:22 +0000 [thread overview]
Message-ID: <20190210042414.GH2217@ZenIV.linux.org.uk> (raw)
In "net/unix/af_unix.c: Set ATIME on socket inode" (back in
2002) we'd grown something rather odd in unix_find_other(). In the
original patch it was
u=unix_find_socket_byname(sunname, len, type, hash);
- if (!u)
+ if (u) {
+ struct dentry *dentry;
+ dentry = u->protinfo.af_unix.dentry;
+ if (dentry)
+ UPDATE_ATIME(dentry->d_inode);
+ } else
goto fail;
These days the code is
u = unix_find_socket_byname(net, sunname, len, type, hash);
if (u) {
struct dentry *dentry;
dentry = unix_sk(u)->path.dentry;
if (dentry)
touch_atime(&unix_sk(u)->path);
} else
goto fail;
but the logics is the same. It's the abstract address case - we have
'\0' in sunname->sun_path[0]. How in hell could that possibly have
non-NULL ->path.dentry and what would it be?
Note that unix_find_socket_byname() returns non-NULL u here only if
u->addr->name->sun_path[0] is equal to sunname->sun_path[0], i.e.
'\0'. There are only two places where we ever might assign non-NULL
to ->path.dentry:
if (sun_path[0]) {
addr->hash = UNIX_HASH_SIZE;
hash = d_backing_inode(path.dentry)->i_ino & (UNIX_HASH_SIZE - 1);
spin_lock(&unix_table_lock);
u->path = path;
list = &unix_socket_table[hash];
} else {
in unix_bind() (in which case u->addr->name->sun_path[0] will not be '\0') and
/* copy address information from listening to new sock*/
if (otheru->addr) {
refcount_inc(&otheru->addr->refcnt);
newu->addr = otheru->addr;
}
if (otheru->path.dentry) {
path_get(&otheru->path);
newu->path = otheru->path;
}
in unix_stream_connect(). And once ->addr is non-NULL, it's never changed,
and ->addr->name contents is never modified afterwards. So we would have
to had the same condition (non-NULL ->path.dentry with '\0' in
->addr->name->sun_path[0]) at earlier point on the listener socket.
Looks like that should be impossible; what am I missing here? Incidentally,
how can the quoted fragment in in unix_stream_connect() be reached with NULL
otheru->addr? After all, otheru is unix_sock of a listener; how could
we possibly have found it if it had NULL ->addr?
Confused...
next reply other threads:[~2019-02-10 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 4:24 Al Viro [this message]
2019-02-11 3:19 ` [RFC] apparently bogus logics in unix_find_other() since 2002 Al Viro
2019-02-11 11:21 ` Solar Designer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210042414.GH2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=solar@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).