From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFCDAC282C2 for ; Sun, 10 Feb 2019 20:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6A172145D for ; Sun, 10 Feb 2019 20:34:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="ZF2VkS99" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726125AbfBJUeK (ORCPT ); Sun, 10 Feb 2019 15:34:10 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41486 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfBJUeK (ORCPT ); Sun, 10 Feb 2019 15:34:10 -0500 Received: by mail-pg1-f194.google.com with SMTP id m1so4002810pgq.8 for ; Sun, 10 Feb 2019 12:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T5evgVv/3N5agDpGGlAPfey5BAyuvk6iEEm7+5v4yAM=; b=ZF2VkS99qv+zSbClzkw2Hhl9eJYvCEPagONF2TVWUy/ZCe+L3NTnBzWsmOgcY2dj2k 5bcfp16d2jld23nHiRFaKTkXQMjDECEVhCKN+qaxUU74XGGrLyO8yLACMeP2CKIYsn3K XXBK7hCHWZM99XvK4jR1UgIRyuUF3hhlNxY1Rol7qDbJIFW1FOOkWXQ2S5GQpdfhjXm5 qaYfrEwvlXBcJiSVTljkIt+43pQhhNq0mPUzOdPC/aBAl6n6F57nuzZHkU1jDut+qLDI 8pdClco6JRTB6cwXLe8vTO1YmNwDcl2EEGdYfPi5roVSfurKEoZTcdR3T2xB8TB0ow7L GgwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5evgVv/3N5agDpGGlAPfey5BAyuvk6iEEm7+5v4yAM=; b=QdyxfYXpTWexJYSm5Bs1TQbYxVMJJ27Zag0RrnNDi+YYmRlPOgJKlmNNmLMpagw3HT U+0o3wozfxzowJP9XLwlec6iBS+5ir17HKreiWNZLblQMXn5g130fa4qkzhInGhJZlo1 ys4qN9U+Xx47hzckrrATVPwZMtfyJYzSENWYJ2mYJIiSpchPbBx596twESiK2mEv72bq gC4GLbGg0sk8dFl9/s8QIb7X0GBH6KL4/0LbKbZr7J9vvAqHFPvYZ9eUS28JRkmWYCl7 2oGJ2+A6+yZ7YNPUdyJMnO4IbBUgn/vcFt2W0EbeT1UyXPDzpVxkWYmQE4vEsVG1peY6 Fe1g== X-Gm-Message-State: AHQUAuaIbesIQ089EL/MuCTu4vaGYazkLZnUpqlpJpxn879exs8Qq1xx IIsA9ns9FhBX+ebL2WvVi3bGdw== X-Google-Smtp-Source: AHgI3IbWQuRm/ahtzKpJbQBhDg/dkLTDChW+RXW6thAmY7pUmH17ITX8G9QwwNxDmbqQeppjOErBVA== X-Received: by 2002:a62:3141:: with SMTP id x62mr33196613pfx.12.1549830849148; Sun, 10 Feb 2019 12:34:09 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h8sm9701933pgv.27.2019.02.10.12.34.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Feb 2019 12:34:08 -0800 (PST) Date: Sun, 10 Feb 2019 12:34:01 -0800 From: Stephen Hemminger To: Aya Levin Cc: David Ahern , netdev@vger.kernel.org, "David S. Miller" , Jiri Pirko , Moshe Shemesh , Eran Ben Elisha , Tal Alon , Ariel Almog Subject: Re: [PATCH for-next 2/4] devlink: fix print of uint64_t Message-ID: <20190210123401.66920387@hermes.lan> In-Reply-To: <1549823329-10377-3-git-send-email-ayal@mellanox.com> References: <1549532202-943-1-git-send-email-eranbe@mellanox.com> <1549823329-10377-1-git-send-email-ayal@mellanox.com> <1549823329-10377-3-git-send-email-ayal@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 10 Feb 2019 20:28:47 +0200 Aya Levin wrote: > This patch prints uint64_t with its corresponding format and avoid implicit > cast to uint32_t. > > Signed-off-by: Aya Levin > Reviewed-by: Moshe Shemesh > Reported-by: Maria Pasechnik > --- > devlink/devlink.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/devlink/devlink.c b/devlink/devlink.c > index a05755385a49..46e2e41c5dfd 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1628,7 +1628,14 @@ static void pr_out_u64(struct dl *dl, const char *name, uint64_t val) > if (val == (uint64_t) -1) > return pr_out_str(dl, name, "unlimited"); > > - return pr_out_uint(dl, name, val); > + if (dl->json_output) { > + jsonw_u64_field(dl->jw, name, val); > + } else { > + if (g_indent_newline) > + pr_out("%s %lu", name, val); > + else > + pr_out(" %s %lu", name, val); > + } > } > > static void pr_out_region_chunk_start(struct dl *dl, uint64_t addr) More conditional code adds bloat and is a nuisance. Why not use print_u64 that already exists. I wish devlink used json_print in a more standard manner.