From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D9AC282C2 for ; Sun, 10 Feb 2019 20:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E16422146F for ; Sun, 10 Feb 2019 20:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="H+HwTjzP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbfBJUma (ORCPT ); Sun, 10 Feb 2019 15:42:30 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:42526 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfBJUma (ORCPT ); Sun, 10 Feb 2019 15:42:30 -0500 Received: by mail-pf1-f193.google.com with SMTP id n74so3001212pfi.9 for ; Sun, 10 Feb 2019 12:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hUH7z1BKx65jEQKaaBroQuFlAQGz6DiNAnqoxdAZLnM=; b=H+HwTjzPJ+RQwoDkgHmLJz1greluq/YfYQ/7bBpkv4mlXPgZNTg5xovGK7op94GXXE 0xRHY/wO9+qz9ctx5xHXfquGAhQIMcIn+qWA21LtfRnoFKGzMdsokfFUfpASQPSDGCBx g8OZZ0Jf6e1j4xMAsA+umCiZCCuDgNEv2LGbE7uRHSwHVJymumOIs57Xtt8MJYWk4P1W yb9ghw/MQw8PG1TC3dNluo1rC1T8z4gtqSqi2ojsi4FrLg4bO+jbBpHlN1+dSagPRh44 B1ItpgQJbN4u5gQuBVdqnhqf4wCWF9OOFnUDfx2YySxakLsYhUogpkAyRViB/d+k4Q1k dX2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hUH7z1BKx65jEQKaaBroQuFlAQGz6DiNAnqoxdAZLnM=; b=AlKkWLXKDdQYJN2e1aooHKepLNzgbKdLKyGPQPBuRNkTfuv1diUiPo3k2J8BWKVUb6 +IxrATiK/90dOhAdBG8VFSg2YwpWXAWD4WhGFbcrGNkAUUhzDpZ9IaGKwzcRnl7zmSgm EFOJLoi0ToUM4vtyOdYjkeHmmxctIX8U2+BapAJxqFNK8Yw4CTeMU6KZWr0BO2W1WD5S CTiGUPhULUMKESlw4f1Kroluz8XtWZyo9VWvRPlGUPvv8EjLUarQOqBXA+uNrAt00cAW BBNVFNC20K4OFUIcTWQEbyq+Y6MT31eF0jm+5k0ZjK4F92IFGecXEQbbiIbbu+tzTJFd 1mRQ== X-Gm-Message-State: AHQUAuYkfmvmn+E55GFtP0fqNxJIva7RIzyDG+khY7D5QUCnjGZob56h F6YPXDeXmF/0Njw+8EBvKSyucw== X-Google-Smtp-Source: AHgI3IYyFBklenuBfiwLaqhS+RXhqPaGMeRgqYuUyeVVV+Pins1J+ckOGNiV4KujoShNS7m49sEcmQ== X-Received: by 2002:aa7:808a:: with SMTP id v10mr21531301pff.8.1549831349241; Sun, 10 Feb 2019 12:42:29 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t24sm10821014pfh.21.2019.02.10.12.42.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Feb 2019 12:42:29 -0800 (PST) Date: Sun, 10 Feb 2019 12:42:22 -0800 From: Stephen Hemminger To: Aya Levin Cc: David Ahern , netdev@vger.kernel.org, "David S. Miller" , Jiri Pirko , Moshe Shemesh , Eran Ben Elisha , Tal Alon , Ariel Almog Subject: Re: [PATCH for-next 4/4] devlink: add health command support Message-ID: <20190210124222.59c5d0aa@hermes.lan> In-Reply-To: <1549823329-10377-5-git-send-email-ayal@mellanox.com> References: <1549532202-943-1-git-send-email-eranbe@mellanox.com> <1549823329-10377-1-git-send-email-ayal@mellanox.com> <1549823329-10377-5-git-send-email-ayal@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 10 Feb 2019 20:28:49 +0200 Aya Levin wrote: > + > +static void cmd_health_help(void) > +{ > + pr_err("Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n"); > + pr_err("Usage: devlink health recover DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health diagnose DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health dump show DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health dump clear DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health set DEV reporter REPORTER_NAME NAME VALUE\n"); > +} > + Minor nit: I prefer that all code and outputs in iproute2 look the same for ease of maintenance and constituency of user experience. Why does devlink not use: static void cmd_health_help(void) { fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n"); fprintf(stderr, " devlink health recover DEV reporter REPORTER_NAME\n"); fprintf(stderr, " devlink health diagnose DEV reporter REPORTER_NAME\n"); ... Or fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n" " devlink health recover DEV reporter REPORTER_NAME\n" " devlink health diagnose DEV reporter REPORTER_NAME\n");