From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ChrB=QR=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 11423C282C2
	for <netdev@archiver.kernel.org>; Sun, 10 Feb 2019 19:44:55 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C9F852145D
	for <netdev@archiver.kernel.org>; Sun, 10 Feb 2019 19:44:54 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="MtCkhuU2"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726096AbfBJTox (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 10 Feb 2019 14:44:53 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:45766 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725958AbfBJTox (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 10 Feb 2019 14:44:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=Jrzr9mBuU9y1D46U3omxiKXvuHJmn5ehD8ByzluOjc4=; b=MtCkhuU2k5otMPq1eGVkpjQxix
        l2NFPoAlb1U6dexprxB2PL5MbPOWZsh9Pt9c1pdMBZdq8iSVKj4Njos7WNrR51zT1f1otp/GSN7Sq
        gJIedxix3Rtth/qkP1fD9BQ3Wy8VqGZKeyigN39CbxyuoS4ujJXKx0XZgFMb2nZiXz2A=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gsv22-0001RG-8g; Sun, 10 Feb 2019 20:44:50 +0100
Date:   Sun, 10 Feb 2019 20:44:50 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: phy: marvell10g: fix usage of new MMD
 modifying helpers
Message-ID: <20190210194450.GI30265@lunn.ch>
References: <a9d88fc1-6ff7-5805-a7d3-7aad7391b4d8@gmail.com>
 <f6705472-58c2-5bad-be0a-b44518a4e72d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f6705472-58c2-5bad-be0a-b44518a4e72d@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, Feb 10, 2019 at 07:58:49PM +0100, Heiner Kallweit wrote:
> When replacing mv3310_modify() with phy_modify_mmd() we missed that
> they behave differently, mv3310_modify() returns 1 on a changed
> register value whilst phy_modify_mmd() returns 0. Fix this by replacing
> phy_modify_mmd() with phy_modify_mmd_changed() where needed.
> 
> Fixes: b52c018ddccf ("net: phy: make use of new MMD accessors")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Sorry, my bad.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew