From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50E8C169C4 for ; Mon, 11 Feb 2019 20:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B11F218A4 for ; Mon, 11 Feb 2019 20:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbfBKUpz (ORCPT ); Mon, 11 Feb 2019 15:45:55 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfBKUpz (ORCPT ); Mon, 11 Feb 2019 15:45:55 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3AC9A14BF7A79; Mon, 11 Feb 2019 12:45:55 -0800 (PST) Date: Mon, 11 Feb 2019 12:45:54 -0800 (PST) Message-Id: <20190211.124554.1686370406673029680.davem@davemloft.net> To: stranche@codeaurora.org Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, steffen.klassert@secunet.com Subject: Re: [PATCH net] af_key: unconditionally clone on broadcast From: David Miller In-Reply-To: <1549571601-395-1-git-send-email-stranche@codeaurora.org> References: <1549571601-395-1-git-send-email-stranche@codeaurora.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Feb 2019 12:45:55 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sean Tranchetti Date: Thu, 7 Feb 2019 13:33:21 -0700 > Attempting to avoid cloning the skb when broadcasting by inflating > the refcount with sock_hold/sock_put while under RCU lock is dangerous > and violates RCU principles. It leads to subtle race conditions when > attempting to free the SKB, as we may reference sockets that have > already been freed by the stack. ... > Suggested-by: Eric Dumazet > Signed-off-by: Sean Tranchetti > --- > Realized I never actually sent this patch out after testing the changes > Eric recommended. Whoops. Better late then never, I suppose... Steffen, I assume you will review and pick this up. Thanks.