From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41952C169C4 for ; Mon, 11 Feb 2019 21:41:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15BEE2081B for ; Mon, 11 Feb 2019 21:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbfBKVl2 (ORCPT ); Mon, 11 Feb 2019 16:41:28 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44508 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726228AbfBKVl1 (ORCPT ); Mon, 11 Feb 2019 16:41:27 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3A9D014BFF807; Mon, 11 Feb 2019 13:41:27 -0800 (PST) Date: Mon, 11 Feb 2019 13:41:26 -0800 (PST) Message-Id: <20190211.134126.1755107367726453752.davem@davemloft.net> To: parav@mellanox.com Cc: netdev@vger.kernel.org Subject: Re: [PATCHv1 net-next] devlink: Add WARN_ON to catch errors of not cleaning devlink objects From: David Miller In-Reply-To: <1549660500-26565-1-git-send-email-parav@mellanox.com> References: <1549660500-26565-1-git-send-email-parav@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Feb 2019 13:41:27 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Parav Pandit Date: Fri, 8 Feb 2019 15:15:00 -0600 > Add WARN_ON to make sure that all sub objects of a devlink device are > cleanedup before freeing the devlink device. > This helps to catch any driver bugs. > > Signed-off-by: Parav Pandit Applied, thanks.