From: David Miller <davem@davemloft.net>
To: hoang.h.le@dektech.com.au
Cc: tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com,
maloy@donjonn.com, ying.xue@windriver.com,
netdev@vger.kernel.org
Subject: Re: [net] tipc: fix skb may be leaky in tipc_link_input
Date: Mon, 11 Feb 2019 18:36:24 -0800 (PST) [thread overview]
Message-ID: <20190211.183624.1085166229826606719.davem@davemloft.net> (raw)
In-Reply-To: <20190211021828.6145-1-hoang.h.le@dektech.com.au>
From: Hoang Le <hoang.h.le@dektech.com.au>
Date: Mon, 11 Feb 2019 09:18:28 +0700
> When we free skb at tipc_data_input, we return a 'false' boolean.
> Then, skb passed to subcalling tipc_link_input in tipc_link_rcv,
>
> <snip>
> 1303 int tipc_link_rcv:
> ...
> 1354 if (!tipc_data_input(l, skb, l->inputq))
> 1355 rc |= tipc_link_input(l, skb, l->inputq);
> </snip>
>
> Fix it by simple changing to a 'true' boolean when skb is being free-ed.
> Then, tipc_link_rcv will bypassed to subcalling tipc_link_input as above
> condition.
>
> Acked-by: Ying Xue <ying.xue@windriver.com>
> Acked-by: Jon Maloy <maloy@donjonn.com>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Applied, thanks.
prev parent reply other threads:[~2019-02-12 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 2:18 [net] tipc: fix skb may be leaky in tipc_link_input Hoang Le
2019-02-12 2:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211.183624.1085166229826606719.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).