From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D23CC282C4 for ; Tue, 12 Feb 2019 05:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 713D220863 for ; Tue, 12 Feb 2019 05:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726040AbfBLFbB (ORCPT ); Tue, 12 Feb 2019 00:31:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48268 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbfBLFbB (ORCPT ); Tue, 12 Feb 2019 00:31:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8C24514C18076; Mon, 11 Feb 2019 21:31:00 -0800 (PST) Date: Mon, 11 Feb 2019 21:31:00 -0800 (PST) Message-Id: <20190211.213100.1304484370993659622.davem@davemloft.net> To: elibr@mellanox.com Cc: netdev@vger.kernel.org, roid@mellanox.com, pablo@netfilter.org, jiri@mellanox.com, saeedm@mellanox.com Subject: Re: [PATCH net-next 1/1] flow_offload: Fix flow action infrastructure From: David Miller In-Reply-To: <20190211075259.39058-1-elibr@mellanox.com> References: <20190211075259.39058-1-elibr@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Feb 2019 21:31:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eli Britstein Date: Mon, 11 Feb 2019 09:52:59 +0200 > Implementation of macro "flow_action_for_each" introduced in > commit e3ab786b42535 ("flow_offload: add flow action infrastructure") > and used in commit 738678817573c ("drivers: net: use flow action > infrastructure") iterated the first item twice and did not reach the > last one. Fix it. > > Fixes: e3ab786b42535 ("flow_offload: add flow action infrastructure") > Fixes: 738678817573c ("drivers: net: use flow action infrastructure") > Signed-off-by: Eli Britstein > Reviewed-by: Roi Dayan Applied, thanks.