From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1812C169C4 for ; Mon, 11 Feb 2019 03:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7F3C20855 for ; Mon, 11 Feb 2019 03:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XI8G+JyV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726226AbfBKDyE (ORCPT ); Sun, 10 Feb 2019 22:54:04 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39418 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfBKDyE (ORCPT ); Sun, 10 Feb 2019 22:54:04 -0500 Received: by mail-pf1-f195.google.com with SMTP id f132so4631758pfa.6 for ; Sun, 10 Feb 2019 19:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1OGQ72+Lt8AjPKBgzYc7nDIywxGL9ChweoC6oSyk+x0=; b=XI8G+JyVXs/sDEOnrOOwqdPSoyy1FFK5zxx5Y+vbY0eznsLyY9Qifdke6PAK37+beO +OQ7YbvBPF6npK8yNVBzRm/HGUWYaIXZgskZwUvqu9XYDZiRwxdE0HFxHXUgOiU7DhmJ LzcMVVAPe0+fAsnIqm+6kvn84tYaQ04DzOulS890hg0aYuwYN+IK2zMe5C/kqmOrY7WA TeVjARPEAjnTl/YMTP5po7sjVuvOpdYFDYDpsppzGLSfbyWZmzKjuJxUIdyl19FHuSlS gJU4mp7D63woxnSdo987jVceYL+oHXGd7z834PskTYM1gflZ/3P8Iy3VqOjr4mw73NZS ScNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1OGQ72+Lt8AjPKBgzYc7nDIywxGL9ChweoC6oSyk+x0=; b=E3zwCl0AD5MUD26IIMBWGikjvJ0+VkcKxLNrYa0XsPMThS7N1/r+KK3olEG/MTS84R T45AkGG3O+2WfxXn05jV9GMCejrCJiACdpoBupQNiMQFZjrBIlvzdYJ5M/qs3NrI7W+M tzIsCsfybrpWetl1B6EeSPE0Dohb5iwOshx8ZCRc+BRbs6jc1+A9TbEN+kQdcohV/sBX 9I1tJogqOghxUWgd0ClqM83r7LM7OM9R4VONtqqg7Kab7cj0Gk7RzP/ya44FNhpIO5BY FrHXmWU5k/C2TMtTriVBB4el+pesoJSCyWJBkRSrhJ1k6J2rLu2BBkjigmb07a1+Nbjb 2y1w== X-Gm-Message-State: AHQUAuadi6BvbW6SV2bZogFg9rpprDnTIW9K9ufliriqjZFzd1g5DcJj +WDxV22rPX4iK5FIYmSksaw= X-Google-Smtp-Source: AHgI3IbGF7h3Wcs8JPsacAw/Gnw5nwN46kO4fTRIIf0zZHoyPzwIoUCtjroRorSwKV1zeN7nP7RlhQ== X-Received: by 2002:a63:cd14:: with SMTP id i20mr31816136pgg.288.1549857243104; Sun, 10 Feb 2019 19:54:03 -0800 (PST) Received: from ast-mbp ([2620:10d:c090:180::1:b7e]) by smtp.gmail.com with ESMTPSA id u186sm12640825pfu.51.2019.02.10.19.54.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 19:54:02 -0800 (PST) Date: Sun, 10 Feb 2019 19:54:00 -0800 From: Alexei Starovoitov To: Martin Lau Cc: "netdev@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Joe Stringer Subject: Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup() Message-ID: <20190211035358.j4muzcj257bkxkqd@ast-mbp> References: <20190209062554.142612-1-kafai@fb.com> <20190210040241.wtsldfavw2vk3afv@ast-mbp> <20190210071513.o56emdqcb23xtng3@kafai-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190210071513.o56emdqcb23xtng3@kafai-mbp.dhcp.thefacebook.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 10, 2019 at 07:15:17AM +0000, Martin Lau wrote: > > > Fixes: c64b7983288e ("bpf: Add PTR_TO_SOCKET verifier type") > > > Cc: Joe Stringer > > > Signed-off-by: Martin KaFai Lau > > > > Applied to bpf tree. > Thanks! > > > > > Martin, if your is_fullsock work depends on it, I can apply the fix > > to bpf-next as well. Just let me know. > Yes, the is_fullsock work depends on it. > I should have mentioned it in this commit log. Ok. I've pushed it to bpf-next as well. Last time we discusses this scenario at netconf and agreed that git should do the right thing, since commit is the same. I think this is a case where I think it makes sense to give it a shot. If we get issues during pulls/merges it will be a lesson to avoid such things in the future, but if we don't try it we won't know. So applied.