From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C72BC169C4 for ; Mon, 11 Feb 2019 04:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35B442146F for ; Mon, 11 Feb 2019 04:08:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EszDreK4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbfBKEIs (ORCPT ); Sun, 10 Feb 2019 23:08:48 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:36851 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbfBKEIs (ORCPT ); Sun, 10 Feb 2019 23:08:48 -0500 Received: by mail-pg1-f196.google.com with SMTP id n2so4388425pgm.3 for ; Sun, 10 Feb 2019 20:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sO2MoJHfG9kmHVBrXaib+Gx/04D1ZJVdek1va7KMxdU=; b=EszDreK4QclI2mDXbNUCfeW8LLfZsuujepRR8SIbnPlQHStwMQdDLdHo76SsRLPvIK 5dyHyGp4Is1ZzUC9bCZwxfXdyFv0r0wrvAYV1GIxOsXPs8smf6QGv3nnWXYhTnpbGMah 2d6EFS76s3YaqCUURrhJNtGlf9tQXSscIz9mzcCRwZoTZikh8AilUYYsDmjWBMCAJYJK 4qE6dHfD2xko93qCwBmfB+XTIXsM2VzlrQtBcHfF+p6TFPsMKOPdgaiM+zmp6zKIIQVa 1hU2cevLCuHQsDzVPaKG5w4iCBDUOH8jbkgN1Chm+HpxRykyhrmXgsvY6Y3qx0+g0eK8 JikA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sO2MoJHfG9kmHVBrXaib+Gx/04D1ZJVdek1va7KMxdU=; b=EhnSo0P/FEu3dFKdOzEosSd4h8OP9EHktYs7hJtYiZh8/+jfygt5SakEAnS9xIINsw PaLCtKyz4F8IYeOM7VVPejcyGDnNpwEv+I7nIVcHZgiKmAdQC8GzyrzXWnrtM9PPNvxP RrN6OKiMqCHUG5IQAeuFwa8d2qmXwozKLG9zg8NJ15mIMF2Re5Y94yhb1B+wU/EiU14i I2u0SlKwVKM53MTovpN8zdPCD7U74Mqo6+A/fH1XsATJf5lVpp0AKFLuQh9gXA9NWJxH YUdSP++PcelZlg9fqnbNxvEC+O2sY7oX3zkke+OZ7FRLg7ph6PSpZ/CsX0dQJek6WRfm Gxag== X-Gm-Message-State: AHQUAuZDNBLp+SaZkPbfUvH3DosqYjmfWil7LujV1ZSh87W9XDXoRABu fbTxmT6DkwOf/k4Vep9a6e+ZkYkf X-Google-Smtp-Source: AHgI3IYLSVt27eo1+W6GUCS0Tt6qiK3Ciyf/2BZx1AsdP4ShYaBurnNVzcePs0kR7T0fNxdNQJUAIw== X-Received: by 2002:a63:3287:: with SMTP id y129mr31956513pgy.337.1549858127445; Sun, 10 Feb 2019 20:08:47 -0800 (PST) Received: from ast-mbp ([2620:10d:c090:180::1:b7e]) by smtp.gmail.com with ESMTPSA id f20sm10456467pfn.177.2019.02.10.20.08.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 20:08:46 -0800 (PST) Date: Sun, 10 Feb 2019 20:08:45 -0800 From: Alexei Starovoitov To: Magnus Karlsson Cc: bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org Subject: Re: [PATCH bpf] xsk: add missing smp_rmb() in xsk_mmap Message-ID: <20190211040844.cwghalpoqwidjyo4@ast-mbp> References: <1549631630-29208-1-git-send-email-magnus.karlsson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549631630-29208-1-git-send-email-magnus.karlsson@intel.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 08, 2019 at 02:13:50PM +0100, Magnus Karlsson wrote: > All the setup code in AF_XDP is protected by a mutex with the > exception of the mmap code that cannot use it. To make sure that a > process banging on the mmap call at the same time as another process > is setting up the socket, smp_wmb() calls were added in the umem > registration code and the queue creation code, so that the published > structures that xsk_mmap needs would be consistent. However, the > corresponding smp_rmb() calls were not added to the xsk_mmap > code. This patch adds these calls. > > Fixes: 37b076933a8e3 ("xsk: add missing write- and data-dependency barrier") > Fixes: c0c77d8fb787c ("xsk: add user memory registration support sockopt") > Signed-off-by: Magnus Karlsson Applied, Thanks