From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70966C169C4 for ; Mon, 11 Feb 2019 20:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D598218A4 for ; Mon, 11 Feb 2019 20:47:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="KiSEO6jf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbfBKUrN (ORCPT ); Mon, 11 Feb 2019 15:47:13 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34500 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbfBKUrM (ORCPT ); Mon, 11 Feb 2019 15:47:12 -0500 Received: by mail-pf1-f194.google.com with SMTP id j18so136548pfe.1 for ; Mon, 11 Feb 2019 12:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=admqwkaG5lh1FTkEW/ac1GyngyGSIJLfPe49QQhkzz4=; b=KiSEO6jfK2JelDa6U7k4363ALxDhEZlUnqZvgtQW7SRLQ0XMhao/9CobgakB2ixce+ YTKZq2kQztlGUmbj7oErod+2ihv08HydvRRbYNTazMqgWC72nH0BokMrdH3BI6YOXrKo GjD8tAbPjEjR7IQKdVjaOATb10nU1ec2MP57uoqdSf3E3I0a3Eoyqn7cy8Y3poEQl0FF kV9tgQbOhF0KlUNVtT3CmnPXVyxEechT9ybLIX552cHRmlxtwPfIKQHqao+7XSxakuib R5H7ZpFt7LTOd64tRxhQHC3qib+V8DFW9IK7fwCAUEo6QIC0jOWuecmUolrvRkfgrg0i V94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=admqwkaG5lh1FTkEW/ac1GyngyGSIJLfPe49QQhkzz4=; b=RbMiw1joXBQkod9ecaRF45ZPrn4qfTFp/xjpjhSPlKcy9vLu/k1eZLYPpKOGeYPnp7 0IJj/b7+Vu0qxAUh8Y8joyp3E+b8EHBNTdnH/dcQAbdbQ0ZQIqjegwH+6qIVZyIDNt4N RbwQd0qHAJ1i6X5TlKZDSLQ+3v7BcEWb4f7qbpr/M6BjzoQ4MMNmJTQEy3pHhNsKlX1T AN05Jb+ORnEKBMZjajRJfDo5ORBNRx6LSaEdhvt2GSHAcQwa5gWgfuWz4FHayGz+9Wib tC9aQ2awsqLw62kusS2DjLkDev/IDTToEXzlEpB2kQUarlKm9ZKmDkgEGtlUcMpUAkjN sx+A== X-Gm-Message-State: AHQUAuY1raejMxT6q20mPeYjVEpT0kp4F3p/5A8NoB0Sb3uVFhDAbpvT QIV5yjw7hIgZSRvNqSeHtxpUew== X-Google-Smtp-Source: AHgI3IbTBLlyiHtm7kKZnIRDGk6I9TyTIGu8eAgsVFw8Xec+BkLFkF9vWnH5PI7IwRFREdlVsHqkew== X-Received: by 2002:a63:4d:: with SMTP id 74mr147404pga.248.1549918032115; Mon, 11 Feb 2019 12:47:12 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id s12sm8407652pfm.120.2019.02.11.12.47.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 12:47:11 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gtITu-0000ni-Po; Mon, 11 Feb 2019 13:47:10 -0700 Date: Mon, 11 Feb 2019 13:47:10 -0700 From: Jason Gunthorpe To: ira.weiny@intel.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Borkmann , netdev@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Andrew Morton , "Kirill A. Shutemov" , Dan Williams Subject: Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1 Message-ID: <20190211204710.GE24692@ziepe.ca> References: <20190211201643.7599-1-ira.weiny@intel.com> <20190211203417.a2c2kbmjai43flyz@linux-r8p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211203417.a2c2kbmjai43flyz@linux-r8p5> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote: > On Mon, 11 Feb 2019, ira.weiny@intel.com wrote: > > Ira Weiny (3): > > mm/gup: Change "write" parameter to flags > > mm/gup: Introduce get_user_pages_fast_longterm() > > IB/HFI1: Use new get_user_pages_fast_longterm() > > Out of curiosity, are you planning on having all rdma drivers > use get_user_pages_fast_longterm()? Ie: > > hw/mthca/mthca_memfree.c: ret = get_user_pages_fast(uaddr & PAGE_MASK, 1, FOLL_WRITE, pages); This one is certainly a mistake - this should be done with a umem. Jason