From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E38C282C4 for ; Tue, 12 Feb 2019 12:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D724218A3 for ; Tue, 12 Feb 2019 12:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbfBLMQX (ORCPT ); Tue, 12 Feb 2019 07:16:23 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:51926 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfBLMQX (ORCPT ); Tue, 12 Feb 2019 07:16:23 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 09080200A7; Tue, 12 Feb 2019 13:16:22 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R7VNCYAky2Io; Tue, 12 Feb 2019 13:16:21 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 9266C20096; Tue, 12 Feb 2019 13:16:21 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.435.0; Tue, 12 Feb 2019 13:16:21 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 124733182658; Tue, 12 Feb 2019 13:16:21 +0100 (CET) Date: Tue, 12 Feb 2019 13:16:21 +0100 From: Steffen Klassert To: David Miller CC: , , Subject: Re: [PATCH net] af_key: unconditionally clone on broadcast Message-ID: <20190212121620.GU3087@gauss3.secunet.de> References: <1549571601-395-1-git-send-email-stranche@codeaurora.org> <20190211.124554.1686370406673029680.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190211.124554.1686370406673029680.davem@davemloft.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 6B6140D8-084C-468D-B800-A8E4EDCBBFAA X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 11, 2019 at 12:45:54PM -0800, David Miller wrote: > From: Sean Tranchetti > Date: Thu, 7 Feb 2019 13:33:21 -0700 > > > Attempting to avoid cloning the skb when broadcasting by inflating > > the refcount with sock_hold/sock_put while under RCU lock is dangerous > > and violates RCU principles. It leads to subtle race conditions when > > attempting to free the SKB, as we may reference sockets that have > > already been freed by the stack. > ... > > Suggested-by: Eric Dumazet > > Signed-off-by: Sean Tranchetti > > --- > > Realized I never actually sent this patch out after testing the changes > > Eric recommended. Whoops. Better late then never, I suppose... > > Steffen, I assume you will review and pick this up. I was not on Cc and overlooked it at the list. Thanks for the pointer! Now applied to the ipsec tree, thanks Sean!