From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C40DFC282CA for ; Tue, 12 Feb 2019 14:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 917C120823 for ; Tue, 12 Feb 2019 14:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="NPtRoXUq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730043AbfBLOC7 (ORCPT ); Tue, 12 Feb 2019 09:02:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35599 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728605AbfBLOCy (ORCPT ); Tue, 12 Feb 2019 09:02:54 -0500 Received: by mail-wr1-f66.google.com with SMTP id t18so2828076wrx.2 for ; Tue, 12 Feb 2019 06:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lCalz13so0yT9FLlCRV3yI401Qfqpo2SioVUk5Ytw+U=; b=NPtRoXUq4DLG2mTF5knAg5RoX+MMQUFH8mhBJahJNfCCfegveDPj8yW/tHkv/AqYqy b9ifMPeYVP4PXYmUfw4Q4uxxr2QjQ3JazFs62rFPGbU5gms7J90etQ+9INUJP/th9AFH lGaMsD+XUbqSylQl89lvCIZKUa4dZwZSKEgfM72Jy5CE91ITMMaKj1lf4sMPidzEsH09 VOEocgkjoUiIfvH5SLkyEUxt4fGMOcL2+QMhyTjoa8NeZt4v7ETzmEaWrs8alAZ1v1ZY pt144EE2eOzy+4nXhq6AePfTqE+7qvSoPPF/FyUa04Vml8xYVOzMP6Ns92sUmILOt8eQ nyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lCalz13so0yT9FLlCRV3yI401Qfqpo2SioVUk5Ytw+U=; b=f8UCylyr6uvGP3uGCZEN6Zx6VsIVrKe3X8Lexw5TiOUJlsJeP1svWHUNgGO/+dH7xm jC+rCbse0p7wgGrrBjNaaSzX7F2PeqkeWWd5XGrxYGSn1r5YhjvG9X4ZgfL7GS60LQPH n+KKThRQmIpJv2HYKmyMKGwSrp0fodMcFrepuPQPb8ddOeHH8sHLlnXYBzsUi+Kn/fpD kSlPNqmqLV2viHDJymnMLnqDBPLNA9XvTaQFbdLWJsEJFFc6AjN8M6NcQVf0GChTscau JB5dN2LLWwxaGreWuBLt7Ak6F9DnrMsrfmbseuMYv/cH1DO1+jnbqx/cAUPpa0D78DBP BS2Q== X-Gm-Message-State: AHQUAub3YqPxfYa4xBfG2LJ6Si7HfJ+EKGFeoGPoI4FXVF5PjcM9NmNo svxcxC9nJb4FEfCkFaS/h8dgXw== X-Google-Smtp-Source: AHgI3IZDn52LHL/5mVjOvk2xJLxnLENExA4jYF99KViHYy1wJhLSZqwXjQ5oAqhUphZCTDywik6dKg== X-Received: by 2002:adf:ba8e:: with SMTP id p14mr2941271wrg.230.1549980172425; Tue, 12 Feb 2019 06:02:52 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id v1sm27309249wrw.90.2019.02.12.06.02.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 06:02:51 -0800 (PST) Date: Tue, 12 Feb 2019 14:53:27 +0100 From: Jiri Pirko To: Ido Schimmel Cc: Florian Fainelli , "netdev@vger.kernel.org" , "David S. Miller" , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , Jiri Pirko , "andrew@lunn.ch" , "vivien.didelot@gmail.com" Subject: Re: [PATCH net-next v4 0/9] net: Remove switchdev_ops Message-ID: <20190212135327.GG2881@nanopsycho> References: <20190211191001.8623-1-f.fainelli@gmail.com> <20190212131443.GA13819@splinter> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212131443.GA13819@splinter> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 12, 2019 at 02:14:47PM CET, idosch@mellanox.com wrote: >On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote: >> Hi all, >> >> This patch series finishes by the removal of switchdev_ops. To get there >> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to >> use a blocking notifier, thus making it consistent with how the objects >> are pushed to the switchdev enabled devices. >> >> Please review and let me know what you think! >> >> David, I would like to get Ido's feedback on this to make sure I did not >> miss something, thank you! > >Hi Florian, > >Why do you still keep switchdev_port_attr_get()? I believe we can remove >it and simplify things. > >After your recent patchset to remove 'PORT_BRIDGE_FLAGS', the only >remaining user of get() is 'PORT_BRIDGE_FLAGS_SUPPORT'. It can be >converted to a blocking set() with 'PORT_PRE_BRIDGE_FLAGS' (or a similar >name). Let's do that in a follow-up. > >I would like to make sure we're in sync with regards to future changes. >After this patchset to get rid of switchdev_ops we can continue to >completely removing switchdev (I believe Jiri approves). The Yes. >prepare-commit model is not really needed and the two switchdev >notification chains can be split into bridge and vxlan specific chains. > >Notifications sent in an atomic context can be handled by drivers >directly in this context. Similar to how FDB/route/neighbour are >handled. It will really simplify things. No need for the defer flag >anymore and tricks like 'PORT_BRIDGE_FLAGS_SUPPORT' and >'PORT_PRE_BRIDGE_FLAGS'. In the atomic context the driver can veto the >requested bridge flags, but program the device from a blocking context >(using a workqueue). Sounds good to me.