netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, William Flanagan <bill@flanagan-consulting.com>
Subject: Re: [iproute PATCH] man: ip-link: Describe promisc mode
Date: Tue, 12 Feb 2019 16:42:45 +0100	[thread overview]
Message-ID: <20190212154245.GM26388@orbyte.nwl.cc> (raw)
In-Reply-To: <20190211113610.6c6604e4@hermes.lan>

Hi,

On Mon, Feb 11, 2019 at 11:36:10AM -0800, Stephen Hemminger wrote:
> On Mon, 11 Feb 2019 10:17:06 +0100
> Phil Sutter <phil@nwl.cc> wrote:
[...]
> > diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> > index 73d37c190fffa..5c327f01b6b45 100644
> > --- a/man/man8/ip-link.8.in
> > +++ b/man/man8/ip-link.8.in
> > @@ -1780,6 +1780,14 @@ flag on the device. Indicates that address can change when interface goes down (
> >  .B NOT
> >  used by the Linux).
> >  
> > +.TP
> > +.BR "promisc on " or " promisc off"
> > +change the
> > +.B PROMISC
> > +flag on the device. This requests receipt of all packets arriving at the NIC
> > +irrespective of their destination MAC address. It is typically used by traffic
> > +sniffers and also set by Linux bridges for their ports.
> 
> This added sentence is confusing. The Linux bridge enables it by default,
> and if a sniffer wants to enable it then it is best done from the application.
> In either case the user should not need to directly set this through ip commands.

Well, "used by traffic sniffers" does not imply they don't set it by
themselves (at least not in the German accent I'm reading it :). And
there probably are ones that don't.

> Yes, there are a lots of incorrect web pages out there that say you need to
> set an interface into promiscious mode (with ifconfig) before adding it to a bridge.
> That might have been true 20 years ago, but hasn't been needed since Linux 2.4

In this case ip-link.8 would become a resource pointing out that bridges
do that by themselves nowadays.

> Bottom line, adding this to the documentation is not going to be helpful.

OK, so I'll send a v2 with that last sentence removed?

Thanks, Phil

      reply	other threads:[~2019-02-12 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 20:22 How to set promiscuous mode William Flanagan
2019-02-11  9:14 ` Phil Sutter
2019-02-11  9:17   ` [iproute PATCH] man: ip-link: Describe promisc mode Phil Sutter
2019-02-11 19:36     ` Stephen Hemminger
2019-02-12 15:42       ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212154245.GM26388@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=bill@flanagan-consulting.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).