From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4079FC43381 for ; Thu, 14 Feb 2019 06:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1532021934 for ; Thu, 14 Feb 2019 06:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405641AbfBNGKp (ORCPT ); Thu, 14 Feb 2019 01:10:45 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49048 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbfBNGKo (ORCPT ); Thu, 14 Feb 2019 01:10:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 36EB814CF8250; Wed, 13 Feb 2019 22:10:44 -0800 (PST) Date: Wed, 13 Feb 2019 22:10:43 -0800 (PST) Message-Id: <20190213.221043.122004348292926904.davem@davemloft.net> To: vishal@chelsio.com Cc: netdev@vger.kernel.org, nirranjan@chelsio.com, indranil@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for SGE doorbell queue timer From: David Miller In-Reply-To: <1550034844-10850-2-git-send-email-vishal@chelsio.com> References: <1550034844-10850-1-git-send-email-vishal@chelsio.com> <1550034844-10850-2-git-send-email-vishal@chelsio.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Feb 2019 22:10:44 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vishal Kulkarni Date: Wed, 13 Feb 2019 10:44:03 +0530 > T6 introduced a Timer Mechanism in SGE called the > SGE Doorbell Queue Timer. With this we can now configure > TX Queues to get CIDX Updates when: > > Time(CIDX == PIDX) >= Timer > > Previously we rely on TX Queue Status Page updates by hardware > for DMA completions. This will make Hardware/Firmware actually > deliver the CIDX Updates as Ingress Queue messages with > commensurate Interrupts. > > So we now have a new RX Path component for processing CIDX Updates > and reclaiming TX Descriptors faster. > > Original work by: Casey Leedom > > Signed-off-by: Vishal Kulkarni Can you at least fix the reverse christmas tree situation for the functions where you add or remove local variables? Thank you.