From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91DBC282CA for ; Wed, 13 Feb 2019 03:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6D0221B1A for ; Wed, 13 Feb 2019 03:41:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="RkBWblqG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732102AbfBMDlI (ORCPT ); Tue, 12 Feb 2019 22:41:08 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:39196 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731996AbfBMDlH (ORCPT ); Tue, 12 Feb 2019 22:41:07 -0500 Received: by mail-pg1-f196.google.com with SMTP id r11so489048pgp.6 for ; Tue, 12 Feb 2019 19:41:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NPtpKwKwL5BP/pufUdENU5Cv1Zj44At1dl8Fsyf1rwY=; b=RkBWblqGNPuC2I0jFJ3ZYlSAplgParK6WnDnQRI6gbKrBTMXOLs6Gs1oqqmAo4+jlH rB8MpluqxiODv75Jlg9yIbWwW2dpSObTnexQkPBZogRjJhBQPOrrVcUwMXPiML2mGoOk eSXJj2ThheX2Su9hlBf6Y1hXjlkTfiOeHMjHQORmWZ8BkrHCeYTSaE9tkuW4ULlXItzs f32NVjvbxKGOvhGGee+CDq78Kdx595Xm908xSXb/CMSPiES2iI1vyoul9nHT90TX3yGB rwVAXmk1NaPn/6NSlZr9GeJFD35n8f0Pt9N/0418xVmFwMI5WAQQP6yOfVrQ47l0IXXq cZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NPtpKwKwL5BP/pufUdENU5Cv1Zj44At1dl8Fsyf1rwY=; b=PCrEqna+5kQLDrkTKGAYmExpx4noFLKO5j8OaxMxHbICq88p91/iqNjQ2AFHpM0DEw mctb9KeQSOVHIoow/GOez4/xxdccjEui/4cPenVnBW95kK2KhQOe/Y6QOUSbt8bjWzTl i/PO2DJjWwyumLyYpcYThAtLAwLtGeIP/ES+pjBiVx959LVf1OJDYcDpdg7rysaJ4IK+ 2M7z6/JfwNtZyTpH9svvqR5jJSAwMY1csAwQAnTsMeGY2RMKpKw11CIkOClGCLyRK5mZ iRCEOjRyVW/ANKMlYMnnuW4qI6iN0D22ku0B7Rs0JvAOkxKmNJ3LjAohJgE7JLovj5UL 33WQ== X-Gm-Message-State: AHQUAuYx2zgQmiXRz0AEjn2X0VIjLyOCM28W9QN5eknilGjCE5kLyP76 JnNeKVF62qJDp+HIbeOokkjhNQ== X-Google-Smtp-Source: AHgI3Ib4ygoMh2NXRn8MZ0GY1YQYu8KZaNgNJO0VnTdDRWei+6oLkUv4j5o+TDI8xKXMDSrFcvzMtQ== X-Received: by 2002:a63:d70a:: with SMTP id d10mr6856974pgg.286.1550029266616; Tue, 12 Feb 2019 19:41:06 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id j197sm22645826pgc.76.2019.02.12.19.41.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 19:41:05 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gtlQ0-0002LK-TI; Tue, 12 Feb 2019 20:41:04 -0700 Date: Tue, 12 Feb 2019 20:41:04 -0700 From: Jason Gunthorpe To: Shiraz Saleem Cc: dledford@redhat.com, davem@davemloft.net, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, mustafa.ismail@intel.com, jeffrey.t.kirsher@intel.com, Anirudh Venkataramanan Subject: Re: [RFC 03/19] net/ice: Add support for ice peer devices and drivers Message-ID: <20190213034104.GA8751@ziepe.ca> References: <20190212214402.23284-1-shiraz.saleem@intel.com> <20190212214402.23284-4-shiraz.saleem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212214402.23284-4-shiraz.saleem@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 03:43:46PM -0600, Shiraz Saleem wrote: > From: Anirudh Venkataramanan > > The E800 series of Ethernet devices has multiple hardware blocks, of > which RDMA is one. The RDMA block isn't interfaced directly to PCI > or any other bus. The RDMA driver (irdma) thus depends on the ice > driver to provide access to the RDMA hardware block. > > The ice driver first creates a pseudo bus and then creates and attaches > a new device to the pseudo bus using device_register(). This new device > is referred to as a "peer device" and the associated driver (i.e. irdma) > is a "peer driver" to ice. Once the peer driver loads, it can call > ice driver functions exposed to it via struct ice_ops. Similarly, ice can > call peer driver functions exposed to it via struct ice_peer_ops. This seems quite big for this straightforward description.. I was going to say I like the idea of using the driver model to connect the drivers, but if it takes so much code ... > + /* check for reset in progress before proceeding */ > + pf = pci_get_drvdata(peer_dev->pdev); > + for (i = 0; i < ICE_MAX_RESET_WAIT; i++) { > + if (!ice_is_reset_in_progress(pf->state)) > + break; > + msleep(100); > + } Use proper locking, not loops with sleeps. Jason