From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Schumaker, Anna" <Anna.Schumaker@netapp.com>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
"trond.myklebust@hammerspace.com"
<trond.myklebust@hammerspace.com>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"dhowells@redhat.com" <dhowells@redhat.com>
Subject: Re: [PATCH] rpc: properly check debugfs dentry before using it
Date: Wed, 13 Feb 2019 08:24:33 +0100 [thread overview]
Message-ID: <20190213072433.GA10225@kroah.com> (raw)
In-Reply-To: <2a029733e094460e2f57bb2d3fc28e7e1757b83e.camel@netapp.com>
On Tue, Feb 12, 2019 at 08:52:53PM +0000, Schumaker, Anna wrote:
> On Tue, 2019-02-12 at 19:27 +0100, Greg Kroah-Hartman wrote:
> > debugfs can now report an error code if something went wrong instead of
> > just NULL. So if the return value is to be used as a "real" dentry, it
> > needs to be checked if it is an error before dereferencing it.
> >
> > This is now happening because of ff9fb72bc077 ("debugfs: return error
> > values, not NULL"), but why debugfs files are not being created properly
> > is an older issue, probably one that has always been there and should
> > probably be looked at...
> >
> > Cc: "J. Bruce Fields" <bfields@fieldses.org>
> > Cc: Jeff Layton <jlayton@kernel.org>
> > Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
> > Cc: Anna Schumaker <anna.schumaker@netapp.com>
> > Cc: linux-nfs@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Reported-by: David Howells <dhowells@redhat.com>
> > Tested-by: David Howells <dhowells@redhat.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> > net/sunrpc/debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I can take this through my tree if people don't object, or it can go
> > through the NFS tree. It does need to get merged before 5.0-final
> > though.
>
> I'm planning another bugfixes pull for 5.0, so I can take this patch and send it
> with the others this week.
Wonderful, thanks for doing this, and sorry for the regression.
greg k-h
prev parent reply other threads:[~2019-02-13 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 18:27 [PATCH] rpc: properly check debugfs dentry before using it Greg Kroah-Hartman
2019-02-12 20:52 ` Schumaker, Anna
2019-02-13 7:24 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213072433.GA10225@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Anna.Schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).