From: Steffen Klassert <steffen.klassert@secunet.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Willem de Bruijn <willemb@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH RFC v2 2/3] net: Support GRO/GSO fraglist chaining.
Date: Wed, 13 Feb 2019 12:49:54 +0100 [thread overview]
Message-ID: <20190213114954.GA3087@gauss3.secunet.de> (raw)
In-Reply-To: <CAF=yD-+Tvyz8x+F+VnZXYDToW-kC2MuPG5Lcna2W+CQwTOMybQ@mail.gmail.com>
On Mon, Jan 28, 2019 at 02:50:34PM -0600, Willem de Bruijn wrote:
> On Mon, Jan 28, 2019 at 2:53 AM Steffen Klassert
> <steffen.klassert@secunet.com> wrote:
> > +
> > + if (skb_needs_linearize(skb, features) &&
> > + __skb_linearize(skb)) {
> > + skb->next = NULL;
> > + kfree_skb_list(skb->next);
>
> inverse order
Oh yes, apparently.
>
> also, I would probably deduplicate with the same branch above in a new
> err_linearize: block
Will do that.
Thanks for the review!
next prev parent reply other threads:[~2019-02-13 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 8:50 [PATCH RFC v2 0/3] Support fraglist GRO/GSO Steffen Klassert
2019-01-28 8:50 ` [PATCH RFC v2 1/3] UDP: enable GRO by default Steffen Klassert
2019-01-28 15:30 ` Paolo Abeni
[not found] ` <9615a29c028dea4f95efa7d1921f67b1a8c1f6e2.camel@redhat.com>
[not found] ` <20190213090406.GW3087@gauss3.secunet.de>
[not found] ` <87f5eb5964c77840eccaaba184039b226a387fc7.camel@redhat.com>
2019-02-13 10:52 ` Steffen Klassert
2019-01-28 8:50 ` [PATCH RFC v2 2/3] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-01-28 20:50 ` Willem de Bruijn
2019-02-13 11:49 ` Steffen Klassert [this message]
2019-01-28 8:50 ` [PATCH RFC v2 3/3] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-01-28 16:37 ` Paolo Abeni
2019-01-28 20:49 ` Willem de Bruijn
2019-02-13 11:48 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213114954.GA3087@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=Jason@zx2c4.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).