From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F34FC282CE for ; Wed, 13 Feb 2019 20:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3F9A2147C for ; Wed, 13 Feb 2019 20:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394528AbfBMUJ7 (ORCPT ); Wed, 13 Feb 2019 15:09:59 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40636 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727049AbfBMUJ7 (ORCPT ); Wed, 13 Feb 2019 15:09:59 -0500 Received: by mail-wr1-f65.google.com with SMTP id q1so3949317wrp.7 for ; Wed, 13 Feb 2019 12:09:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/FqhF8jhU0Jz2C+iI/hypc6N4ekBRjDLEuQyaqM+0mE=; b=mO7kYdcrWK2EhPuZyz5EwU3GzujoWMvIs0lCDFwTxo+leu4PEp1Lb3fx5QcA+PpzzQ BPd4NNIFrKYE0OcF2OGd24JYGC4CHRSdxckFW+KV/PR3d6YLd0IvyzpxnoXgj07EtZOd L33I/KWe11V+70ewmdUgi9DMNvo/0TREkaCtCA4NBcFKoLdRZyiLZrEjF8oWz7Wckxu6 lfBa8TJOKa89H+GlarpP6Iig2mZvzVvnIGjLUmdWAkBkuHDsUiEkoNmR/pux+jrENKJF sZ/yG1moq3AR/BzjjOluXKaO6cmBODmifLioh6W7+fUnNyo4BxHcZojNAhwg59dbW7tV OGtQ== X-Gm-Message-State: AHQUAuZUzXdR1zp62RcUOu58+kZrMtKP7BBaquk8qb7K9pINUBa8MGuo vmGWZcv+qLV/1eO8ZDr43mE4MxM+ X-Google-Smtp-Source: AHgI3Ia1r5Vf59aa7c1I4oqy5sUjwLPkH7dVFSjqbYuzbJ7KM8J2CKcKAkJvs7+Q9iKXdBEgkbBJfg== X-Received: by 2002:a5d:4486:: with SMTP id j6mr1682784wrq.41.1550088597280; Wed, 13 Feb 2019 12:09:57 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:c934:57a:5587:ac0c]) by smtp.gmail.com with ESMTPSA id q8sm283213wrr.9.2019.02.13.12.09.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 12:09:56 -0800 (PST) From: Luca Boccassi To: netdev@vger.kernel.org Cc: stephen@networkplumber.org, Luca Boccassi , =?UTF-8?q?Cl=C3=A9ment=20Hertling?= Subject: [RFC iproute2] ip route: get: allow zero-length subnet mask Date: Wed, 13 Feb 2019 20:09:53 +0000 Message-Id: <20190213200954.32271-1-bluca@debian.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A /0 subnet mask is theoretically valid, but ip route get doesn't allow it: $ ip route get 1.0.0.0/0 need at least a destination address Remove the check so that it can go through: $ ip/ip route get 1.0.0.0/0 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000 cache Reported-by: Clément Hertling Signed-off-by: Luca Boccassi --- Stephen et al, this was reported by a Debian user: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737 It makes sense to me at a cursory glance, but sending as RFC as I'm not 100% familiar with the route get function. ip/iproute.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 5f58a3b3..d78f43d8 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -2041,11 +2041,6 @@ static int iproute_get(int argc, char **argv) argc--; argv++; } - if (req.r.rtm_dst_len == 0) { - fprintf(stderr, "need at least a destination address\n"); - return -1; - } - if (idev || odev) { int idx; -- 2.20.1