From: David Miller <davem@davemloft.net>
To: marc.w.gonzalez@free.fr
Cc: vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, netdev@vger.kernel.org,
niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com,
nsekhar@ti.com, peter.ujfalusi@ti.com
Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode
Date: Thu, 14 Feb 2019 09:33:40 -0800 (PST) [thread overview]
Message-ID: <20190214.093340.1523955807518975542.davem@davemloft.net> (raw)
In-Reply-To: <d566afe6-4c63-a59f-0141-cc979b29aedf@free.fr>
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
Date: Thu, 14 Feb 2019 17:46:54 +0100
> On 14/02/2019 17:38, David Miller wrote:
>
>> From: Vinod Koul <vkoul@kernel.org>
>> Date: Tue, 12 Feb 2019 19:49:22 +0530
>>
>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
>>> index 8ff12938ab47..7b54b54e3316 100644
>>> --- a/drivers/net/phy/at803x.c
>>> +++ b/drivers/net/phy/at803x.c
>>> @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
>>> return phy_write(phydev, AT803X_DEBUG_DATA, val);
>>> }
>>>
>>> +static inline int at803x_enable_rx_delay(struct phy_device *phydev)
>>> +{
>>> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
>>> + AT803X_DEBUG_RX_CLK_DLY_EN);
>>> +}
>>> +
>>> +static inline int at803x_enable_tx_delay(struct phy_device *phydev)
>>> +{
>>> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
>>> + AT803X_DEBUG_TX_CLK_DLY_EN);
>>> +}
>>> +
>>
>> Please do not use the inline directive in foo.c files, let the compiler
>> decide.
>
> Isn't the compiler free to ignore the "inline" hint?
I'm not going into this, but our rules are to not use the inline keyword
except in header files where they are required in order to not emit a
static copy of the function into every file that includes the header.
next prev parent reply other threads:[~2019-02-14 17:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 14:19 [PATCH] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-13 7:02 ` Peter Ujfalusi
2019-02-15 10:16 ` Vinod Koul
2019-02-13 13:12 ` Niklas Cassel
2019-02-13 13:29 ` Andrew Lunn
2019-02-13 13:40 ` Marc Gonzalez
2019-02-13 17:40 ` Niklas Cassel
2019-02-13 17:59 ` Florian Fainelli
2019-02-13 20:07 ` Niklas Cassel
2019-02-13 21:38 ` Florian Fainelli
2019-02-14 10:49 ` Peter Ujfalusi
2019-02-14 12:39 ` Niklas Cassel
2019-02-14 13:22 ` Peter Ujfalusi
2019-02-14 15:06 ` Niklas Cassel
2019-02-15 0:14 ` Florian Fainelli
2019-02-14 16:38 ` David Miller
2019-02-14 16:46 ` Marc Gonzalez
2019-02-14 17:33 ` David Miller [this message]
2019-02-15 9:58 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214.093340.1523955807518975542.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).