netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com,
	peterz@infradead.org, acme@redhat.com
Subject: Re: [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env
Date: Thu, 14 Feb 2019 13:33:11 +0100	[thread overview]
Message-ID: <20190214123311.GA7465@krava> (raw)
In-Reply-To: <20190209011705.2160185-6-songliubraving@fb.com>

On Fri, Feb 08, 2019 at 05:17:01PM -0800, Song Liu wrote:
> bpf_prog_info contains information necessary to annotate bpf programs.
> This patch saves bpf_prog_info for bpf programs loaded in the system.
> 
> perf-record saves bpf_prog_info information as headers to perf.data.
> A new header type HEADER_BPF_PROG_INFO is introduced for this data.

please move those 2 changes into separate patches then

it's hard to make comments when I don't see the rest of
the patches on the list please resend the patchset

thanks,
jirka

  parent reply	other threads:[~2019-02-14 12:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09  1:16 [PATCH 0/9] perf annotation of BPF programs Song Liu
2019-02-09  1:16 ` [PATCH 1/9] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-02-09  1:16 ` [PATCH 2/9] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-02-09  1:16 ` [PATCH 3/9] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-02-09  1:17 ` [PATCH 4/9] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-02-09  1:17 ` [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-02-14 12:26   ` Jiri Olsa
2019-02-14 17:01     ` Song Liu
2019-02-14 12:33   ` Jiri Olsa [this message]
2019-02-14 17:03     ` Song Liu
2019-02-15  7:41       ` Jiri Olsa
2019-02-11 18:54 ` [PATCH 0/9] perf annotation of BPF programs Arnaldo Carvalho de Melo
2019-02-11 20:10   ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214123311.GA7465@krava \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).