From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C55C43381 for ; Thu, 14 Feb 2019 12:39:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF2652229F for ; Thu, 14 Feb 2019 12:39:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XwafM33z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389909AbfBNMjc (ORCPT ); Thu, 14 Feb 2019 07:39:32 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37050 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfBNMjc (ORCPT ); Thu, 14 Feb 2019 07:39:32 -0500 Received: by mail-lj1-f194.google.com with SMTP id r10-v6so5094912ljj.4 for ; Thu, 14 Feb 2019 04:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6tcJL5Bb1tGEx/bJ/bhRXs3NZOIJNs+GaB0XOJhsJ2c=; b=XwafM33zZTqaL6lOB+AIdbJIi+/yy+smuYCum15O+O9TlkJJmNnmxYCw4GomnYX71N VE9+YC2Xh7ceMDDcReiWEW9p20tU/mSBr3+knNfRToNJ13nJCbR8wfCNzOUieb54HUFL g4BWokdUWYY/DbhLibVpeTznNjjAz4D6fwO9znr1znpl0MKjQnvp4qd6igWHO2NFXZIC HgKJmV3mhwvXVuY6ZlSLY9GsbOmjMat3JD4GoKzdOYENR/Jsy5Hq4c5tFCoN9uIGVKXd dR3r936yu7dXktCHNiw0we7CvDinC3IFjoUp6xXaTll7wroEpRYwjU6NrttQTQCIWHKp 1vsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6tcJL5Bb1tGEx/bJ/bhRXs3NZOIJNs+GaB0XOJhsJ2c=; b=Vf/OfoXj2VPP+rou5sLm7EZmqqLDrubBlHhe8FeIiQ0QYZ0sGzF2H2JxNmK42aEMxo SjYjwfZrsdqeTlAQ56+6721mJu1VK5e1m6Szo/08cBIxJX7QIT2xzFqIhFKLMgQKF0q/ 3GPojL/5cr7swfCZRrrGyc4o1RnpeS5keHo91NYizqW7xAn9tGq8aRr8cp2WnBt513Ta xgdp/BamNL12ImTFUsG+u/04Md50+uItfESy+bTcIjLEMP162C6lDklbdswrZlWbNnks RXDbxiE66ztr+oBRBXScdNHEMAOwAtPpBG1Fe8wDyCWieYDVld02xLJSa0z4tQJKG2os iMUQ== X-Gm-Message-State: AHQUAua3Q2MhiiyHI0kV0wj0Ew4RC0tjGsU327+Mq40/jJhvt3eI7Aqz AYmWqJajscUL+pvQRhbHc+hjlQ== X-Google-Smtp-Source: AHgI3IaqRlbGplm/VcCgLTpgCwf1kb+SgqNd1bpTeOIysKFCb9tpf/yq3JQJYNlUoxcdGpAxi9drNg== X-Received: by 2002:a2e:884b:: with SMTP id z11-v6mr2234087ljj.68.1550147970066; Thu, 14 Feb 2019 04:39:30 -0800 (PST) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id t19-v6sm418618lje.23.2019.02.14.04.39.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 14 Feb 2019 04:39:29 -0800 (PST) Date: Thu, 14 Feb 2019 13:39:22 +0100 From: Niklas Cassel To: Peter Ujfalusi Cc: Marc Gonzalez , Andrew Lunn , Florian Fainelli , Vinod Koul , David S Miller , linux-arm-msm@vger.kernel.org, Bjorn Andersson , netdev@vger.kernel.org, "Nori, Sekhar" Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode Message-ID: <20190214123922.GA28897@centauri.ideon.se> References: <20190212141922.12849-1-vkoul@kernel.org> <20190213131206.GA460@centauri.lan> <20190213132900.GA24589@lunn.ch> <1ab5edac-a36c-9dc5-52e5-dbd3b70e7728@free.fr> <20190213174034.GA6954@centauri.lan> <3356ff05-8d08-591e-03bf-9d846f79097b@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3356ff05-8d08-591e-03bf-9d846f79097b@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 14, 2019 at 12:49:36PM +0200, Peter Ujfalusi wrote: > Hi Niklas, > > On 13/02/2019 19.40, Niklas Cassel wrote: > > On Wed, Feb 13, 2019 at 02:40:18PM +0100, Marc Gonzalez wrote: > >> On 13/02/2019 14:29, Andrew Lunn wrote: > >> > >>>> So we have these modes: > >>>> > >>>> PHY_INTERFACE_MODE_RGMII: TX and RX delays disabled > >>>> PHY_INTERFACE_MODE_RGMII_ID: TX and RX delays enabled > >>>> PHY_INTERFACE_MODE_RGMII_RXID: RX delay enabled, TX delay disabled > >>>> PHY_INTERFACE_MODE_RGMII_TXID: TX delay enabled, RX delay disabled > >>>> > >>>> What I don't like with this patch, is that if we specify phy-mode > >>>> PHY_INTERFACE_MODE_RGMII_TXID, this patch will enable TX delay, > >>>> but RX delay will not be explicitly set. > >>> > >>> That is not the behaviour we want. It is best to assume the device is > >>> in a random state, and correctly enable/disable all delays as > >>> requested. Only leave the hardware alone if PHY_INTERFACE_MODE_NA is > >>> used. > >> > >> That's what my patch did: > >> https://www.spinics.net/lists/netdev/msg445053.html > >> > >> But see Florian's remarks: > >> https://www.spinics.net/lists/netdev/msg445133.html > > > > Hello Marc, > > > > I saw that comment from Florian. However that was way back in 2017. > > Maybe the phy-modes were not as well defined back then? > > > > Andrew recently suggested to fix the driver so that it conforms with the > > phy-modes, and fix any SoC that specified an incorrect phy-mode in DT > > and thus relied upon the broken behavior of the PHY driver: > > https://www.spinics.net/lists/netdev/msg445133.html > > > > > > So, I've rebased your old patch, see attachment. > > I suggest that Peter test it on am335x-evm. > > with the patch + s/rgmii-txid/rgmii-id in the am335x-evmsk.dts ethernet > is working. > I don't have am335x-evm to test, but it has the same PHY as evmsk. > Florian's concern was that this PHY driver looked at "phy-mode" from the perspective of the MAC rather than the PHY. However, if s/rgmii-txid/rgmii-id is the correct fix for am335x-evm, then this means that this PHY driver was just broken. If the driver had misinterpreted the perspective, then the correct fix for am335x-evm would have been s/rgmii-txid/rgmii-rxid. So considering that this driver seems to be really broken (rather then just inverted perspective), perhaps we can merge the patch I attached in my previous email after all? (Together with a s/rgmii-txid/rgmii-id in the am335x-evmsk.dts.) Kind regards, Niklas > > am335x-evm appears to rely on the current broken behavior of the PHY > > driver, so we will probably need to fix the am335x-evm according to this: > > https://www.spinics.net/lists/netdev/msg445117.html > > and merge that as well. > > > > > > Andrew, Florian, do you both agree? > > > > > > Kind regards, > > Niklas > > > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki