From: David Miller <davem@davemloft.net>
To: paul.kocialkowski@bootlin.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
michal.simek@xilinx.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read
Date: Fri, 15 Feb 2019 20:21:38 -0800 (PST) [thread overview]
Message-ID: <20190215.202138.1915616474041185856.davem@davemloft.net> (raw)
In-Reply-To: <20190215161708.18645-1-paul.kocialkowski@bootlin.com>
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Date: Fri, 15 Feb 2019 17:17:08 +0100
> Some PHY drivers like the generic one do not provide a read_status
> callback on their own but rely on genphy_read_status being called
> directly.
>
> With the current code, this results in a NULL function pointer call.
> Call genphy_read_status instead when there is no specific callback.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Applied, thanks.
Unfortunately I only noticed your updated version with the Fixes tag
after pushing this version out. I'll be more careful next time :)
prev parent reply other threads:[~2019-02-16 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 16:17 [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read Paul Kocialkowski
2019-02-15 16:23 ` Andrew Lunn
2019-02-15 16:29 ` Paul Kocialkowski
2019-02-15 17:01 ` Andrew Lunn
2019-02-16 4:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215.202138.1915616474041185856.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).