From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A2EC43381 for ; Fri, 15 Feb 2019 02:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C48452192B for ; Fri, 15 Feb 2019 02:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729144AbfBOCwG (ORCPT ); Thu, 14 Feb 2019 21:52:06 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:43847 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbfBOCwG (ORCPT ); Thu, 14 Feb 2019 21:52:06 -0500 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 15 Feb 2019 03:52:03 +0100 Received: from localhost (nwb-a10-snat.microfocus.com [10.120.13.202]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Fri, 15 Feb 2019 02:51:35 +0000 Date: Fri, 15 Feb 2019 10:51:30 +0800 From: David Chang To: Heiner Kallweit Cc: Realtek linux nic maintainers , netdev@vger.kernel.org, Martti Laaksonen Subject: Re: r8169 Driver - Poor Network Performance Since Kernel 4.19 Message-ID: <20190215025130.GH7193@linux-kyyb.suse> References: <172787aa-9ef5-091d-f70f-baf89fe0b1ee@gmail.com> <20190131023240.GF25745@linux-kyyb.suse> <856b3a75-5daf-6ce8-7fa3-0405e3cefe97@gmail.com> <20190214024527.GG7193@linux-kyyb.suse> <47a0819f-5ec3-6d73-210e-235d6bbcaab1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47a0819f-5ec3-6d73-210e-235d6bbcaab1@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Heiner, On Feb 14, 2019 at 07:17:44 +0100, Heiner Kallweit wrote: > Hi David, > > On 14.02.2019 03:45, David Chang wrote: > > Hi Heiner, > > > > On Feb 05, 2019 at 19:50:30 +0100, Heiner Kallweit wrote: > >> Hi David, > >> > >> meanwhile there's the following bug report matching what reported. > >> It's even the same chip version (RTL8168h). > >> https://bugzilla.redhat.com/show_bug.cgi?id=1671958 > >> > >> Symptom there is also a significant number of rx_missed packets. > >> Could you try what I mentioned there last: > >> Try building a kernel with the call to rtl_hw_aspm_clkreq_enable(tp, true) at the > >> end of rtl_hw_start_8168h_1() being disabled. > > > > After disabled the aspm function that you mentioned, we finally got the > > positive testing result. And the rx_missed error was gone. If without > > the patch, the receive side get back to bad performance. > > > Good to know, thanks. I also checked with Realtek, they confirmed that their Windows > driver uses some heuristics to disable ASPM under high load. So it seems like there > is some hw issue. Open so far is whether this affects certain chip versions only. > Let's see whether they can provide more information. Ok! > Disabling ASPM in general would hurt notebook users because based on some past > measurements we know ASPM can significantly save energy. I understand, thanks! regards, David > > > kernel: r8169: loading out-of-tree module taints kernel. > > kernel: r8169: module verification failed: signature and/or required key missing - tainting kernel > > kernel: libphy: r8169: probed > > kernel: r8169 0000:01:00.0 eth0: RTL8168h/8111h, ec:8e:b5:5a:2c:f5, XID 54100880, IRQ 128 > > kernel: r8169 0000:01:00.0 eth0: jumbo features [frames: 9200 bytes, tx checksumming: ko] > > kernel: r8169 0000:01:00.0 enp1s0: renamed from eth0 > > kernel: Generic PHY r8169-100:00: attached PHY driver [Generic PHY] (mii_bus:phy_addr=r8169-100:00, irq=IGNORE) > > kernel: r8169 0000:01:00.0 enp1s0: Link is Up - 1Gbps/Full - flow control off > > > > NIC statistics: > > tx_packets: 1653804 > > rx_packets: 1555966 > > tx_errors: 0 > > rx_errors: 0 > > rx_missed: 0 > > align_errors: 0 > > tx_single_collisions: 0 > > tx_multi_collisions: 0 > > unicast: 1555884 > > broadcast: 78 > > multicast: 4 > > tx_aborted: 0 > > tx_underrun: 0 > > > > iperf receive: > > ----------------------------------------------------------- > > Server listening on 5201 > > ----------------------------------------------------------- > > Accepted connection from 10.x.x.x, port 55516 > > [ 5] local 10.x.x.x port 5201 connected to 10.x.x.x port 58172 > > [ ID] Interval Transfer Bitrate > > [ 5] 0.00-1.00 sec 108 MBytes 906 Mbits/sec > > [ 5] 1.00-2.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 2.00-3.00 sec 112 MBytes 940 Mbits/sec > > [ 5] 3.00-4.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 4.00-5.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 5.00-6.00 sec 112 MBytes 942 Mbits/sec > > [ 5] 6.00-7.00 sec 112 MBytes 939 Mbits/sec > > [ 5] 7.00-8.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 8.00-9.00 sec 112 MBytes 938 Mbits/sec > > [ 5] 9.00-10.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 10.00-11.00 sec 112 MBytes 941 Mbits/sec > > [...] > > [ 5] 50.00-51.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 51.00-52.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 52.00-53.00 sec 112 MBytes 942 Mbits/sec > > [ 5] 53.00-54.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 54.00-55.00 sec 111 MBytes 934 Mbits/sec > > [ 5] 55.00-56.00 sec 112 MBytes 942 Mbits/sec > > [ 5] 56.00-57.00 sec 112 MBytes 937 Mbits/sec > > [ 5] 57.00-58.00 sec 112 MBytes 941 Mbits/sec > > [ 5] 58.00-59.00 sec 111 MBytes 932 Mbits/sec > > [ 5] 59.00-60.00 sec 112 MBytes 942 Mbits/sec > > [ 5] 60.00-60.04 sec 4.06 MBytes 939 Mbits/sec > > - - - - - - - - - - - - - - - - - - - - - - - - - > > [ ID] Interval Transfer Bitrate > > [ 5] 0.00-60.04 sec 6.57 GBytes 940 Mbits/sec receiver > > > > regards, > > David > > > Heiner >