From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E364EC43381 for ; Fri, 15 Feb 2019 09:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96DC821B1A for ; Fri, 15 Feb 2019 09:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550224731; bh=YSauvzlg7CVehptu+83mfirZBkDnrCK5pDSLWTM34r0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BdhEv3N6kMK+3lQ8M8CMzt9kQpuD/wn4+BClfvuDjJXUpZZDjX14Wuca+uK07LSKY NPFOm9AuJGnUmjT7SFAIMQryjM3/Sj10txIHTkcVW9QonJDpr8T2Poh6l/7Yb+Q15u k3Si3ybb27Nk1QECqKzYit3psjPvu1wayJXmOp1I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405450AbfBOJ6u (ORCPT ); Fri, 15 Feb 2019 04:58:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:50000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726122AbfBOJ6u (ORCPT ); Fri, 15 Feb 2019 04:58:50 -0500 Received: from localhost (unknown [106.199.107.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C42E221924; Fri, 15 Feb 2019 09:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550224730; bh=YSauvzlg7CVehptu+83mfirZBkDnrCK5pDSLWTM34r0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zrw+BmmgiTUin1tGVCxmwRFi7wt8GvU/vWM+BFr5r1TsC0qpUqEbWay9ZM5alY/+a xHRC9IbC4mgZMDgA4ArVegZ1RziMFXmwaOhXzsbcISLIhQvhjwSbFpyrWJP5QynL2R JWf8k+sRVBOnsmHBwh9/gfIfIltbkaxkTfISOZ2I= Date: Fri, 15 Feb 2019 15:28:43 +0530 From: Vinod Koul To: David Miller Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com, marc.w.gonzalez@free.fr Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode Message-ID: <20190215095843.GE21884@vkoul-mobl> References: <20190212141922.12849-1-vkoul@kernel.org> <20190214.083828.206479765039661735.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214.083828.206479765039661735.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 14-02-19, 08:38, David Miller wrote: > From: Vinod Koul > Date: Tue, 12 Feb 2019 19:49:22 +0530 > > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > index 8ff12938ab47..7b54b54e3316 100644 > > --- a/drivers/net/phy/at803x.c > > +++ b/drivers/net/phy/at803x.c > > @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > > return phy_write(phydev, AT803X_DEBUG_DATA, val); > > } > > > > +static inline int at803x_enable_rx_delay(struct phy_device *phydev) > > +{ > > + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0, > > + AT803X_DEBUG_RX_CLK_DLY_EN); > > +} > > + > > +static inline int at803x_enable_tx_delay(struct phy_device *phydev) > > +{ > > + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0, > > + AT803X_DEBUG_TX_CLK_DLY_EN); > > +} > > + > > Please do not use the inline directive in foo.c files, let the compiler > decide. Sure, this was in existing code, will fix up current occurrences as well. Thanks -- ~Vinod