From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B42CC43381 for ; Fri, 15 Feb 2019 13:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E752021929 for ; Fri, 15 Feb 2019 13:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="S8D0oWBl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfBONrF (ORCPT ); Fri, 15 Feb 2019 08:47:05 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41241 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfBONrF (ORCPT ); Fri, 15 Feb 2019 08:47:05 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9E49C220AB; Fri, 15 Feb 2019 08:47:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 15 Feb 2019 08:47:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+CPAjb FO+HJN0hK7SjuX0kRKDL+cZrVRHs1evyii08U=; b=S8D0oWBl7Q71sqen0wYhAe /yEOGLtS0wjFDRriQ6dGscpOCr1NQ7nxuGkATeifXW+t4JKfW2ekv/zLoKs764Fa funXrWGEH1riGEkF4o/GBkgB2iXCJo0nCALw7yr2XvJJ/ueYrTdcTdYFehOpZovS kfk56Rnjb7j7X52AJbLE0lZY7HXYSm7GaMYBkEDpkB9VhAPfNdNXe0Tl+4T7VE6e uJO/QtQTKDEH7MiPoGgEFmFZOqRhPFew9ZX3oonTqUgzZPYIXiljGAwlQgYR3akp 0fxDH6guaJX8ONdRV/GeMZTDHHdYC8hw6xyFYzKuJNX5pV4bOJlSX4dnodqPiVxQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtjedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfh ggtggujggfsehttdertddtredvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehi ughoshgthhesihguohhstghhrdhorhhgqeenucfkphepjeelrddujeeirdejrdduudehne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhgnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (bzq-79-176-7-115.red.bezeqint.net [79.176.7.115]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F54710314; Fri, 15 Feb 2019 08:47:02 -0500 (EST) Date: Fri, 15 Feb 2019 15:47:00 +0200 From: Ido Schimmel To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net Subject: Re: [PATCH] net: sched: matchall: verify that filter is not NULL in mall_walk() Message-ID: <20190215134700.GA13875@splinter> References: <20190215113041.GA10511@splinter> <20190215121120.4971-1-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215121120.4971-1-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 02:11:20PM +0200, Vlad Buslov wrote: > Check that filter is not NULL before passing it to tcf_walker->fn() > callback. This can happen when mall_change() failed to offload filter to > hardware. > > Signed-off-by: Vlad Buslov Works for me. Thanks Fixes: ed76f5edccc9 ("net: sched: protect filter_chain list with filter_chain_lock mutex") Reported-by: Ido Schimmel Tested-by: Ido Schimmel