From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, GAPPY_SUBJECT,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C36C43381 for ; Fri, 15 Feb 2019 17:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36FC021927 for ; Fri, 15 Feb 2019 17:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=c0d3.blue header.i=@c0d3.blue header.b="RnNr3wco" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfBORUN (ORCPT ); Fri, 15 Feb 2019 12:20:13 -0500 Received: from mail.aperture-lab.de ([138.201.29.205]:35454 "EHLO mail.aperture-lab.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfBORUN (ORCPT ); Fri, 15 Feb 2019 12:20:13 -0500 Date: Fri, 15 Feb 2019 18:20:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c0d3.blue; s=2018; t=1550251210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPWvpi8TDinh7a7C/8wFkLzjxZtaAcpQ3+4oXSs91JE=; b=RnNr3wcokXZdhPGX8qzv4lXhzAMG/jfaJlX3ehRs3GKbMPlB8rjz8uxgxrUrQ6vSx72N05 m/Bw6Gn76Tu7OUv4MXJY4tXwO9aSb0jn1w5WfriAEjxL8AZzxilQiAPXzI2DJUjzpR0Fwe N398+oVZRTVEMlIQ273e8+GM25jvMXz9JUodS475XBnmf7cNtWxQZjbFBy11tOvcW2mx1J LSNud6d+0EvUWxfzfyI+Hkv66EyfIPrkJWQtw+z6YferXm+56edTO26aYqL9tu93XJlJEQ 85+4gVgtAJHGmWh4qzA32UBBia5mOWbyFFvAzJQ7Vn31Plm+oZs3uROYdJt6Eg== From: Linus =?utf-8?Q?L=C3=BCssing?= To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: netdev@vger.kernel.org, Jiri Pirko , David Bauer Subject: Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets Message-ID: <20190215172007.GB1472@otheros> References: <20190214124301.6222-1-linus.luessing@c0d3.blue> <1687264.beubBEU3KB@bentobox> <20190214134452.GA1602@otheros> <11497659.iQavgr9jVl@bentobox> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11497659.iQavgr9jVl@bentobox> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=c0d3.blue; s=2018; t=1550251210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPWvpi8TDinh7a7C/8wFkLzjxZtaAcpQ3+4oXSs91JE=; b=Bf/pu8ZDYi6F4NqyEuMEtIAd1b7Oc3PA5Om+y2wOeniS51XW1dSMG8qDpUDvPocPqV+4XD Rlz2JZFb9rxurDqZk8npfoWV2BRR5bykpU7neKoI8PiJdYeemyGbH3X9hedSTpbjKeqFU/ 91H/D9XJrbOXYmJkHesvsog0a7GhgVy9Di8LOftMJM6igfiteGPxCBlLtQ/qDSYJwS9DgR VLYO2W3nNbrjEE0QYrThRkhWIcR59yY2hER/jIGGFkuWSL0rZnnmK3oeCF7y7hNwbUsMLK W3fpA8xXTjIW2CQ0f82hIOYhhsSobPKUKsewfpdztlQpQpn2rggobbaOPI30rw== ARC-Seal: i=1; s=2018; d=c0d3.blue; t=1550251210; a=rsa-sha256; cv=none; b=addXYo1X2nmKZZNwhSFTikDiq5o21Yre80mthXzPPl/iq6qk+yeuLcPhN8gY+0MfpstdDJ L6vthcEIyBuFI2Te6loOG5FV6rVP8dCcWvw1fVZcHZxGBWcjxDisffK3xBHXa7motmWesg SIgT19+cTkYj/wiZjQPQ51fqDlxVCS1XAyy146kmQUZaJV+4WJkjNeyPCcazU9OsKba0ul p8+EU2E6d96IZxzZbrKb7SqWuGMdlYvbPTm6mIabYU0bF4unG3u2y1k4wRAf2pqirK7L5t kdR0x3Fd64wB3FsLsl1lTqyYofSgRd/H1pt3BfXDuiizPCJBr7YSGYfNY7CMOg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=linus.luessing@c0d3.blue smtp.mailfrom=linus.luessing@c0d3.blue Authentication-Results: ORIGINATING; auth=pass smtp.auth=linus.luessing@c0d3.blue smtp.mailfrom=linus.luessing@c0d3.blue Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 14, 2019 at 03:04:54PM +0100, Sven Eckelmann wrote: > On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote: > [...] > > > No new sysfs config files. > > > > Why? The bridge for instance does the same. > > https://patchwork.open-mesh.org/patch/16763/ - here the quote > > On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: > > I strongly believe it is a huge mistake to use sysfs for things like > > this. This should be done via generic netlink api. > > We don't need to configuration interfaces - we only need the preferred one. If > this is sysfs for you guys then we should not have started with generic > netlink at all. And why wasn't this brought up now *after* the stuff was > merged by David. It isn't the first time that I've stated clearly that there > should be no new sysfs configuration files when we switch to genl. > > If it now preferred to have sysfs again for configuration then please discuss > it with the netdev folks and find out how the new generic netlink interface > can be removed again before the next release. > > Kind regards, > Sven Sorry, then this is all my misunderstanding. I have no issue with removing the sysfs part from this patch (I liked sysfs for prototyping/testing/scripting, but as we have all configuration options available in batctl that works for me, too). Thanks for the clarifications. Regards, Linus