From: Julian Wiedmann <jwi@linux.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-s390@vger.kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Stefan Raspl <raspl@linux.ibm.com>,
Ursula Braun <ubraun@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>
Subject: [PATCH net-next 1/7] s390/qeth: allow manual recovery when device is SOFTSETUP
Date: Fri, 15 Feb 2019 19:22:25 +0100 [thread overview]
Message-ID: <20190215182231.90709-2-jwi@linux.ibm.com> (raw)
In-Reply-To: <20190215182231.90709-1-jwi@linux.ibm.com>
Once a qeth ccwgroup device is set online, it's also armed for internal
recovery. So allow for testing that code path via sysfs, regardless of
whether the interface is up or down.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
drivers/s390/net/qeth_core_sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c
index 30f61608fa22..485a335669ba 100644
--- a/drivers/s390/net/qeth_core_sys.c
+++ b/drivers/s390/net/qeth_core_sys.c
@@ -316,7 +316,7 @@ static ssize_t qeth_dev_recover_store(struct device *dev,
if (!card)
return -EINVAL;
- if (card->state != CARD_STATE_UP)
+ if (!qeth_card_hw_is_reachable(card))
return -EPERM;
i = simple_strtoul(buf, &tmp, 16);
--
2.16.4
next prev parent reply other threads:[~2019-02-15 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 18:22 [PATCH net-next 0/7] s390/qeth: updates 2019-02-15 Julian Wiedmann
2019-02-15 18:22 ` Julian Wiedmann [this message]
2019-02-15 18:22 ` [PATCH net-next 2/7] s390/qeth: use a static Output Queue array Julian Wiedmann
2019-02-15 18:22 ` [PATCH net-next 3/7] s390/qeth: reduce ethtool statistics Julian Wiedmann
2019-02-15 18:22 ` [PATCH net-next 4/7] s390/qeth: move ethtool code into its own file Julian Wiedmann
2019-02-15 18:22 ` [PATCH net-next 5/7] s390/qeth: overhaul ethtool statistics Julian Wiedmann
2019-02-15 18:22 ` [PATCH net-next 6/7] s390/qeth: add support for ETHTOOL_GRINGPARAM Julian Wiedmann
2019-02-15 18:22 ` [PATCH net-next 7/7] s390/qeth: split out OSN netdev ops Julian Wiedmann
2019-02-16 4:35 ` [PATCH net-next 0/7] s390/qeth: updates 2019-02-15 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215182231.90709-2-jwi@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).