From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA7AC43381 for ; Fri, 15 Feb 2019 21:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D515222D7 for ; Fri, 15 Feb 2019 21:36:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S61lzg8l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392290AbfBOVg0 (ORCPT ); Fri, 15 Feb 2019 16:36:26 -0500 Received: from mail-pf1-f202.google.com ([209.85.210.202]:41548 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728755AbfBOVg0 (ORCPT ); Fri, 15 Feb 2019 16:36:26 -0500 Received: by mail-pf1-f202.google.com with SMTP id 75so8490192pfq.8 for ; Fri, 15 Feb 2019 13:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=KrKKdsc8imNuE8YENetk+EHktMprD4Idx069Z7p23+k=; b=S61lzg8ljEjPXYyi4qaDDqnwLPfjoU5tdGY7MGa0v+/VVRLfVaI3vVBVepwQVV6dbo 1TUUoVVpiXQLL2V61nmLlgO7jGKveMQqVnckB+0+F8+gPV+MIa4s/KBdxFIsiG+YXSky r+F0I8wY5o8BRrmhuSiKD3oNLiDt1FJRu57fr1dSRzV59F43HUZZ+5mmQAYu6avRBEN7 1ugkchw0egXISJfCCXam4llf5DteAZPmxkrmcrRtu/ustyNE29V3ft++YDpkdYfWyOnj owj5vIozZh6J+yZdtHOOSxGNikhAum1Uk4c0Lzud02B5nukR8TtRM4TJnnEROUYwPgn5 5lIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=KrKKdsc8imNuE8YENetk+EHktMprD4Idx069Z7p23+k=; b=Yiw5WxYK0CuP/EqYZkby8H+HY7LWlwrgsv6fNy7rfyGHrjBbhW+7KVhZ3LxNn5X/Dy wGI5eO9FWNqncpfxpJPmphM+r5XgWijtJdKHUpKRsis5iGaV2vdb7lbgEPs9uDDPRftw 89JidL98vi0oxDFul8P1RPjVOZmnpGkNQqoOThIwHBYe9BfYJId0hRBNNXDlshm4csq3 4I93IMs6FUQMZkw5OM99o52Wc4hzejSOHAgVa+yMKHsKBwARVgzo0vM/REw0NkCyRBPS SQZvP7b2gDzY//po8aRo/aJPaukHTbA9UOTBsPWGHBCCRZ6TekZElVDcp8S8WTcy2gyC EFTg== X-Gm-Message-State: AHQUAuajWJC56yy1Dun1Q1ZvisCuSt+1xgLnuYZ886M3hSBaKWVNhPOq g0q8mvfANgs74wDOldNqRn2rFoyFL/ch8g== X-Google-Smtp-Source: AHgI3IYTa0JJQ2dSocRRNm/18Hf1BtZtlUSVR9mYXEqE1r1eis+JA0o42vq0QK9u4r4e7tJwGpqk7MLi8ol2DA== X-Received: by 2002:a17:902:1aa:: with SMTP id b39mr3683328plb.139.1550266585750; Fri, 15 Feb 2019 13:36:25 -0800 (PST) Date: Fri, 15 Feb 2019 13:36:19 -0800 Message-Id: <20190215213621.183537-1-edumazet@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog Subject: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet , Neal Cardwell , Yuchung Cheng , soukjin bae Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org soukjin bae reported a crash in tcp_v4_err() that we root caused to a missing initialization. Second patch adds a sanity check in tcp_v4_err() to avoid future potential problems. Ignoring an ICMP message is probably better than crashing a machine. Eric Dumazet (2): tcp: clear icsk_backoff in tcp_write_queue_purge() tcp: tcp_v4_err() should be more careful net/ipv4/tcp.c | 2 +- net/ipv4/tcp_ipv4.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.21.0.rc0.258.g878e2cd30e-goog