From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B9CC10F00 for ; Sat, 16 Feb 2019 21:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 010E1222DD for ; Sat, 16 Feb 2019 21:46:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbfBPVqF (ORCPT ); Sat, 16 Feb 2019 16:46:05 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57416 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbfBPVqE (ORCPT ); Sat, 16 Feb 2019 16:46:04 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E71D014F6F6F0; Sat, 16 Feb 2019 13:46:03 -0800 (PST) Date: Sat, 16 Feb 2019 13:46:01 -0800 (PST) Message-Id: <20190216.134601.2089518577404430254.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: hauke.mehrtens@intel.com, netdev@vger.kernel.org, jarod@redhat.com, hauke@hauke-m.de, stable@vger.kernel.org Subject: Re: [PATCH] net: Fix for_each_netdev_feature on Big endian From: David Miller In-Reply-To: <8e03f4cb-11e2-9e85-ed5e-019da79b3806@gmail.com> References: <20190215165854.25842-1-hauke.mehrtens@intel.com> <20190215.202453.382883236911745765.davem@davemloft.net> <8e03f4cb-11e2-9e85-ed5e-019da79b3806@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Feb 2019 13:46:04 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Sat, 16 Feb 2019 13:01:28 -0800 > This commit added a call to fls64(), but not the needed include. > > This might break some uses I think. > > I suggest the following fix : > > diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h > index c50cedb65cf56fe7d722a5a321b714ed83f449a0..d3f61011f4346e4ea80b61f88bd24541dd006014 100644 > --- a/include/linux/netdev_features.h > +++ b/include/linux/netdev_features.h > @@ -11,6 +11,7 @@ > #define _LINUX_NETDEV_FEATURES_H > > #include > +#include > #include > > typedef u64 netdev_features_t; Ok I'm build testing that right now, thanks. ==================== >From 8681ef1f3d295bd3600315325f3b3396d76d02f6 Mon Sep 17 00:00:00 2001 From: "David S. Miller" Date: Sat, 16 Feb 2019 13:44:39 -0800 Subject: [PATCH] net: Add header for usage of fls64() Fixes: 3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian") Suggested-by: Eric Dumazet Signed-off-by: David S. Miller --- include/linux/netdev_features.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index fce28562bed2..4c76fe2c8488 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -11,6 +11,7 @@ #define _LINUX_NETDEV_FEATURES_H #include +#include #include typedef u64 netdev_features_t; -- 2.20.1