From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EB3C43381 for ; Sat, 16 Feb 2019 16:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77C29222A3 for ; Sat, 16 Feb 2019 16:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="F5/Ha802" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730658AbfBPQA5 (ORCPT ); Sat, 16 Feb 2019 11:00:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55049 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbfBPQA5 (ORCPT ); Sat, 16 Feb 2019 11:00:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7A92ZDT9ZNT2kYhnWhJflyNvW/aoWyIujvBfxMEuNiw=; b=F5/Ha802uGqUZu9OdrB6E7d0oR rYXHR7qFFL1oh7O9T9mDJ3kvG/DLGENpRGkUAxmKGhEZJ+JuUXZKN3olkWQ1TwFtY/UkFaql2dWq7 z4t/IR5e0XhHFQVILAnvX+Q6rCfuOfjQQowTpERegN6BAatCqErno6UMPtFGtIvpd3A8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gv2Ob-0000EQ-CE; Sat, 16 Feb 2019 17:00:53 +0100 Date: Sat, 16 Feb 2019 17:00:53 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 1/2] net: phy: add helpers for handling C45 10GBT AN register values Message-ID: <20190216160053.GP5699@lunn.ch> References: <60b2e19d-e138-dfa0-fa79-19f3cbece99e@gmail.com> <5c217a09-dac8-d8db-3a38-c9a621ae55a6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c217a09-dac8-d8db-3a38-c9a621ae55a6@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 09:57:49PM +0100, Heiner Kallweit wrote: > Similar to the existing helpers for the Clause 22 registers add helpers > to deal with converting Clause 45 advertisement registers to / from > link mode bitmaps. > > Note that these helpers are defined in linux/mdio.h, not like the > Clause 22 helpers in linux/mii.h. Reason is that the Clause 45 register > constants are defined in uapi/linux/mdio.h. And uapi/linux/mdio.h > includes linux/mii.h before defining the C45 register constants. Hi Heiner You add three helpers, but the followup patch only uses one of them. Maybe you should wait until you have real uses of the other two? Or just add the one helper. Andrew