From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DF6C43381 for ; Sat, 16 Feb 2019 20:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5771821916 for ; Sat, 16 Feb 2019 20:37:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=c0d3.blue header.i=@c0d3.blue header.b="LIKgJa8Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730471AbfBPUhY (ORCPT ); Sat, 16 Feb 2019 15:37:24 -0500 Received: from mail.aperture-lab.de ([138.201.29.205]:34862 "EHLO mail.aperture-lab.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729018AbfBPUhY (ORCPT ); Sat, 16 Feb 2019 15:37:24 -0500 Date: Sat, 16 Feb 2019 21:37:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c0d3.blue; s=2018; t=1550349441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UxWsVdh1RQTLB/rfMkJdIEIqlQdnMEJqYNcC+p8+wDY=; b=LIKgJa8Y/sRCeuWBebpJTgkgO+o41JryaxIot1s76oZSK1z6fDNsrTngwKrjX5F9664X1h UdrXdeGhLIWpIRU7znXZd3LwaCnZ+Aj2YqwbVovS7oWaxsSPuHFXPb8ynJhihJ6fhWQ55v NqkaiMVdC8KehrQPrQVZVhSYA80pGMFSlkh+1O8K3yThPG60RkXQtqya096wJGt+lDaxy8 4TsCau/ti8DFHrWp1F+cJO/M1Fx5ERt176wcKHDz8aw8ZZNAcEpGXCvDb46U1MoaTdmqH+ Q9Pe5AB3JR604XRSp395Uf0iB5A/i4xYJittTB5ZndNFz/xEm4VebTp/hyOzWg== From: Linus =?utf-8?Q?L=C3=BCssing?= To: nikolay@cumulusnetworks.com Cc: Ido Schimmel , netdev@vger.kernel.org, roopa@cumulusnetworks.com, wkok@cumulusnetworks.com, anuradhak@cumulusnetworks.com, bridge@lists.linux-foundation.org, davem@davemloft.net, stephen@networkplumber.org Subject: Re: [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled Message-ID: <20190216203719.GC25057@otheros> References: <20190215130427.29824-1-nikolay@cumulusnetworks.com> <20190215171332.GA1472@otheros> <479a1acf-c7f3-4e6f-4246-e1583e98d356@cumulusnetworks.com> <20190216184353.GA10888@splinter> <0FE44F84-AD68-4FC0-8FEB-D033CF6159D2@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=c0d3.blue; s=2018; t=1550349441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UxWsVdh1RQTLB/rfMkJdIEIqlQdnMEJqYNcC+p8+wDY=; b=d5Z0C9vm2xmZaUmh5HTBJAnXJSi4MyBj+hJ5LIBQ75lzf59xmIrDFJaZ6YXrWyP5mHkl7z qdKsQSyqVGOQqNjjLo9Jd5nscJSN3bgGPOSqFcW3PVyuQ5IhdCsyFfmZnu2apMTXtF47KM mBJcjieIIKw1Rf8ki4A/urycuydydZGiWGBZXG1cwPqfztLVGWEHM00zXzx01lY8ICZd5K tJGWoPsko4so67V73dtQuClCU7M47nyi/ckYIDIlPuR80IMa2SZaHGMzBNze/CEZFp48O3 f7su0tmgY0jJgCZ2s79g47rH1QX0QtPjHtOLVx08+xONmDi9z6aTLZtNYbWRdw== ARC-Seal: i=1; s=2018; d=c0d3.blue; t=1550349441; a=rsa-sha256; cv=none; b=HR4yIPvtPDzuX7P/DbnGx7ubDs5DdsOVGoKJBG6FwR4eFGmps9r4UJhedBhsFyt6HdNzjE H5j9UQ5ptRw51RV4Vukq1GBpWDySW8C2HlxYg4BJ+00Xo9L98gQ3YNWtuWHGoH01sMwjuH FEzRfeqolw8HwwJEsYjBs/TxAhyCqjPBkT0AoHm6/DnoQ9K360WK5Tpexw6FHuMzM8mgI2 fNxqw9qPZP64RFecrx+sUGWtI5V/gquPWS5l9TNdsghKSdiGDLZDY4c3C/eZGIXvRnCBIF LfTcb7zFvUe63xbOlsaghkS7siOsStEqenpmf2NLpKrOKl5y/LpfWknDUyo+AA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=linus.luessing@c0d3.blue smtp.mailfrom=linus.luessing@c0d3.blue Authentication-Results: ORIGINATING; auth=pass smtp.auth=linus.luessing@c0d3.blue smtp.mailfrom=linus.luessing@c0d3.blue Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 16, 2019 at 09:27:26PM +0200, nikolay@cumulusnetworks.com wrote: > >>The no querier condition is not currently reflected via switchdev, so > >>the behavior you're proposing in your patch is what actually happens > >in > >>the data plane. > >> > >>We already hit the problem Linus mentioned in commit b00589af3b04 > >>("bridge: disable snooping if there is no querier"). Namely, IPv6 ND > >>broke because a port joined before the bridge was created. > >> > >>I introduced a workaround in commit 9d45deb04c59 ("mlxsw: spectrum: > >>Treat IPv6 unregistered multicast as broadcast"). I'm interested to > >>know > >>what other vendors are doing. Can you elaborate? > >> > > > >Exactly like your fix. :) Flood it, this patch unfortunately breaks it  > >because of mrouters flag, but we can retain the behaviour > >by forwarding only known mdsts to their ports and flooding > >unregistered mcast when there is no querier. I think that is > >what others do by default too, actually I think they flood with querier > >as well. Maybe unknown mcast flooding should be controlled by a flag > >when a querier is present > >because we've had this behaviour for a long time, personally I'd have > >it on > >by default. > > Ugh, mispoke please read the above statement to be only about no querier. > I meant flooding v6 link-local always. And for routable IPv6 multicast, how would you detect multicast listeners on the local link in absence of a querier?