From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EAEC43381 for ; Sun, 17 Feb 2019 23:47:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A0D2218A6 for ; Sun, 17 Feb 2019 23:47:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfBQXrW (ORCPT ); Sun, 17 Feb 2019 18:47:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42874 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfBQXrW (ORCPT ); Sun, 17 Feb 2019 18:47:22 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4565912339A63; Sun, 17 Feb 2019 15:47:21 -0800 (PST) Date: Sun, 17 Feb 2019 15:47:20 -0800 (PST) Message-Id: <20190217.154720.1503278506915285087.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, ncardwell@google.com, ycheng@google.com, soukjin.bae@samsung.com Subject: Re: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() From: David Miller In-Reply-To: <20190215213621.183537-1-edumazet@google.com> References: <20190215213621.183537-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 15:47:21 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Fri, 15 Feb 2019 13:36:19 -0800 > soukjin bae reported a crash in tcp_v4_err() that we > root caused to a missing initialization. > > Second patch adds a sanity check in tcp_v4_err() to avoid > future potential problems. Ignoring an ICMP message > is probably better than crashing a machine. Series applied, thanks Eric. Want me to queue these up for -stable?