From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88BDC43381 for ; Sun, 17 Feb 2019 23:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B12FA2177B for ; Sun, 17 Feb 2019 23:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbfBQXwI (ORCPT ); Sun, 17 Feb 2019 18:52:08 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42910 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfBQXwI (ORCPT ); Sun, 17 Feb 2019 18:52:08 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 95FF812363E1D; Sun, 17 Feb 2019 15:52:07 -0800 (PST) Date: Sun, 17 Feb 2019 15:52:06 -0800 (PST) Message-Id: <20190217.155206.75010948411009821.davem@davemloft.net> To: weiyongjun1@huawei.com Cc: yang.wei9@zte.com.cn, mcgrof@kernel.org, yuehaibing@huawei.com, hch@lst.de, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: sgi: use GFP_ATOMIC under spin lock From: David Miller In-Reply-To: <20190216014809.142801-1-weiyongjun1@huawei.com> References: <20190216014809.142801-1-weiyongjun1@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 15:52:07 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Date: Sat, 16 Feb 2019 01:48:09 +0000 > The function meth_init_tx_ring() is called from meth_tx_timeout(), > in which spin_lock is held, so we should use GFP_ATOMIC instead. > > Fixes: 8d4c28fbc284 ("meth: pass struct device to DMA API functions") > Signed-off-by: Wei Yongjun Applied.