From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A68C43381 for ; Sun, 17 Feb 2019 02:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D414421917 for ; Sun, 17 Feb 2019 02:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C7G0EZQj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbfBQCqY (ORCPT ); Sat, 16 Feb 2019 21:46:24 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40443 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbfBQCqX (ORCPT ); Sat, 16 Feb 2019 21:46:23 -0500 Received: by mail-pf1-f196.google.com with SMTP id h1so6786938pfo.7 for ; Sat, 16 Feb 2019 18:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a92NeL5tfekSy2DdMlVPY2WMYbQ9v4FtOA7ILhCJIlE=; b=C7G0EZQjuDzzIujlu3ti9QFQjQk0oE9LZNyNWMmisBbf8GTtMf2B/Urqz+79OsMJGp PZvwdKBmgJ6d1hWE5nP8ENqhwV35MLj9jC0uNhBiF4JxW7iJR5/PtgdjNYGQvcn1eNuc Cvoo5bBeJ1/Egn/Yq7tZZERKB1quS0Oxc+1rekrCW67SDfrG5//GKHhMMmO2WF2EDf7I o4Z3othoVMjc80MoVpqtVTs85iYFYVHMKlhhu/RGG0jRhjoQT43VX1ZoUAaDD5lp2gl6 6M2QvnFrCRvBgDkfVV8ewDxBONysCRnRhS6BZ/4WH6YuqAE+bWBX/qRLPwTYOembAq+Y oDhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a92NeL5tfekSy2DdMlVPY2WMYbQ9v4FtOA7ILhCJIlE=; b=DnHE8nQTHGaXkB2kh16T+7yVPn+/iYpJP4Ll8VIyaIsILE969BU3EEo14Zqkzff8zI Baj+9D2z91GMWbbWwtZCSvIOq5ROB3QieR8XgJS9TNYsd5wd9gkU8eDid3InZAMmOq7w 2J0ZNuTAXp4ZwSuj8kZpQ5wPlCGnzKbHgOd52dlhbBWtJ/epBOJCIqn5pBtxX3MQ4NXc TrLqDV6GkILldxMRT378E1Lufxqy71WaKdL9S9ysovVIJD16ZuqZXpHXvWPTtgofUoI7 Es4If8jbxi3KBKYm9OaJTT9KRJV39F6P0jPsUCh/Zq6qoCbul8a5zb0Vv11KEEYklq4/ FRoQ== X-Gm-Message-State: AHQUAuaEClrMrj3mck5la3xpkbXrerPDTEPly/lO6ynia/nXu12QQchO FGSUoSFJ0/XLSRtjsw9fdzE= X-Google-Smtp-Source: AHgI3Ib5sNSHX6PrnFOxEfejLry3i+QT/8wPSv4U4VoubgimDB30xsvDU0TebtLGoWYL+gTpzYTfKA== X-Received: by 2002:a63:f5f:: with SMTP id 31mr12117852pgp.186.1550371583175; Sat, 16 Feb 2019 18:46:23 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:1af4]) by smtp.gmail.com with ESMTPSA id x11sm10325892pgp.88.2019.02.16.18.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 18:46:20 -0800 (PST) Date: Sat, 16 Feb 2019 18:46:18 -0800 From: Alexei Starovoitov To: David Ahern Cc: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Peter Oskolkov Subject: Re: [PATCH bpf-next] selftests: bpf: test_lwt_ip_encap: add negative tests. Message-ID: <20190217024616.kisygfnlqsrtlh7m@ast-mbp.dhcp.thefacebook.com> References: <20190215234933.208398-1-posk@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 16, 2019 at 04:13:12PM -0700, David Ahern wrote: > On 2/15/19 4:49 PM, Peter Oskolkov wrote: > > @@ -178,7 +205,7 @@ set -e # exit on error > > # configure IPv4 GRE device in NS3, and a route to it via the "bottom" route > > ip -netns ${NS3} tunnel add gre_dev mode gre remote ${IPv4_1} local ${IPv4_GRE} ttl 255 > > ip -netns ${NS3} link set gre_dev up > > - ip -netns ${NS3} addr add ${IPv4_GRE} dev gre_dev > > + ip -netns ${NS3} addr add ${IPv4_GRE} nodad dev gre_dev > > nodad is only effective for IPv6. > > other than that LGTM. Thanks for the update. > > Reviewed-by: David Ahern Applied as-is. Pls send a follow up if you feel strongly about it. Thanks