From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iwK6=QZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A615EC43381
	for <netdev@archiver.kernel.org>; Mon, 18 Feb 2019 19:59:44 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7E8AF21773
	for <netdev@archiver.kernel.org>; Mon, 18 Feb 2019 19:59:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727486AbfBRT7n (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 18 Feb 2019 14:59:43 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:53540 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725308AbfBRT7n (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 18 Feb 2019 14:59:43 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 788F1108F3338;
        Mon, 18 Feb 2019 11:59:42 -0800 (PST)
Date:   Mon, 18 Feb 2019 11:59:42 -0800 (PST)
Message-Id: <20190218.115942.2123254635644904862.davem@davemloft.net>
To:     eric.dumazet@gmail.com
Cc:     edumazet@google.com, netdev@vger.kernel.org, ncardwell@google.com,
        ycheng@google.com, soukjin.bae@samsung.com
Subject: Re: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <8e6280f3-ea5b-48bd-4dc0-da134d4125d2@gmail.com>
References: <20190215213621.183537-1-edumazet@google.com>
        <20190217.154720.1503278506915285087.davem@davemloft.net>
        <8e6280f3-ea5b-48bd-4dc0-da134d4125d2@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Feb 2019 11:59:42 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 17 Feb 2019 18:20:21 -0800

> 
> 
> On 02/17/2019 03:47 PM, David Miller wrote:
>> From: Eric Dumazet <edumazet@google.com>
>> Date: Fri, 15 Feb 2019 13:36:19 -0800
>> 
>>> soukjin bae reported a crash in tcp_v4_err() that we
>>> root caused to a missing initialization.
>>>
>>> Second patch adds a sanity check in tcp_v4_err() to avoid
>>> future potential problems. Ignoring an ICMP message
>>> is probably better than crashing a machine.
>> 
>> Series applied, thanks Eric.
>> 
>> Want me to queue these up for -stable?
>> 
> 
> Yes please, I put no Fixes: tag because it seemed to be a day-0 bug.

Done.