From: David Miller <davem@davemloft.net>
To: vlomovtsev@marvell.com
Cc: sgoutham@cavium.com, rric@kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dnelson@redhat.com
Subject: Re: [PATCH v2 3/8] net: thunderx: make CFG_DONE message to run through generic send-ack sequence
Date: Mon, 18 Feb 2019 15:33:10 -0800 (PST) [thread overview]
Message-ID: <20190218.153310.393264778478086662.davem@davemloft.net> (raw)
In-Reply-To: <20190218095159.3847-4-vlomovtsev@marvell.com>
From: Vadim Lomovtsev <vlomovtsev@marvell.com>
Date: Mon, 18 Feb 2019 09:52:14 +0000
> @@ -169,6 +169,20 @@ static int nicvf_check_pf_ready(struct nicvf *nic)
> return 1;
> }
>
> +static int nicvf_send_cfg_done(struct nicvf *nic)
> +{
> + union nic_mbx mbx = {};
> +
> + mbx.msg.msg = NIC_MBOX_MSG_CFG_DONE;
> + if (nicvf_send_msg_to_pf(nic, &mbx)) {
> + netdev_err(nic->netdev,
> + "PF didn't respond to CFG DONE msg\n");
> + return 0;
> + }
> +
> + return 1;
> +}
...
> @@ -1515,8 +1528,7 @@ int nicvf_open(struct net_device *netdev)
> nicvf_enable_intr(nic, NICVF_INTR_RBDR, qidx);
>
> /* Send VF config done msg to PF */
> - mbx.msg.msg = NIC_MBOX_MSG_CFG_DONE;
> - nicvf_write_to_mbx(nic, &mbx);
> + nicvf_send_cfg_done(nic);
If the one and only call site doesn't even bother to check the return
value, just make it return void.
Thanks.
next prev parent reply other threads:[~2019-02-18 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 9:52 [PATCH v2 0/8] nic: thunderx: fix communication races between VF & PF Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 1/8] net: thunderx: correct typo in macro name Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 2/8] net: thunderx: replace global nicvf_rx_mode_wq work queue for all VFs to private for each of them Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 3/8] net: thunderx: make CFG_DONE message to run through generic send-ack sequence Vadim Lomovtsev
2019-02-18 23:33 ` David Miller [this message]
2019-02-19 11:21 ` [EXT] " Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 4/8] net: thunderx: add nicvf_send_msg_to_pf result check for set_rx_mode_task Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 6/8] net: thunderx: add mutex to protect mailbox from concurrent calls for same VF Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 5/8] net: thunderx: rework xcast message structure to make it fit into 64 bit Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 7/8] net: thunderx: add LINK_CHANGE message handler at nicpf Vadim Lomovtsev
2019-02-18 9:52 ` [PATCH v2 8/8] net: thunderx: remove link change polling code and info from nicpf Vadim Lomovtsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218.153310.393264778478086662.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dnelson@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=vlomovtsev@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).