From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B99C10F00 for ; Tue, 19 Feb 2019 10:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6E6D20818 for ; Tue, 19 Feb 2019 10:33:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="EWxaB6sv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbfBSKdn (ORCPT ); Tue, 19 Feb 2019 05:33:43 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40566 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728763AbfBSKdh (ORCPT ); Tue, 19 Feb 2019 05:33:37 -0500 Received: by mail-wr1-f67.google.com with SMTP id q1so21576332wrp.7 for ; Tue, 19 Feb 2019 02:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XQDyHqOvUcj4FAsXSdC/kmRv0ETWzYOwOSqV3VOHxjk=; b=EWxaB6svBcGce8egr76tIBw/782BQMLvjnzkjOjg4yc44l+vYRPgz7zAEd44nga+aF sZ4w7Ahsx+HzE7jWtnAaXvFz0lxhB/YTA2Z5i4ZDezSoBcvNXjcACED1bD8ZUW58AFc/ sG1CeoPMFlNAXXegui3D4QqD9+mFIcpzwxx4VCQgNulNg2K51Eqt41XaDXwimO+u7mIe G0uYnEFZPY8aqdpqmxxJ09240qunyKMOxwyKH6tp7pgyUAoAe14osiblCaNrOd0DQtxd iuAlQA1lVGlYcaaQun7L7erF6Fr7EAaSxY050XkHNxrQsd7zo14Zo5jUNIApGT1xLROO dusA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XQDyHqOvUcj4FAsXSdC/kmRv0ETWzYOwOSqV3VOHxjk=; b=e86Nut8xMcArIhYpOwbphxlWc7nM+2c1UjOYWuk5of5lB7HrU/KI8OaR+yfFN/WJuP T1Hp2IoBTkbqhFdOsFu8b0IwyXgvwi4Ej/2KaKMtmyOhZdIfqEH5lE2PJ/tpY7o2CwQM CSym29CYnkrsEN5bWypozDlSbK8r1rQNZFhdDpwoTjecRq/pmOFZ5H7KyIAwwS0EnhqW Z+GugyZ1JhpEpNYPlBJUT9Ql625z2DDZZKslL5x59uR+6PPF1zyedDnjqgFtK5NcSZ1N mASgf7iRUI1bkHllsftC18G7DvdC/hRFjGzTqpvkyvwCG+NMfsUG9x3dyQ7vwjIGLe5B EFkA== X-Gm-Message-State: AHQUAubUcN8PE//8mNwc/KeFyOPDsDx5Pfai9TxIc1fHbVHC2mVk3hkb SMXW58Ln55yY0bnN19I+ceU6Zv6JF3w= X-Google-Smtp-Source: AHgI3IaFbHVffEoKhsDwURPZP1wXsemt11fQfRTJE1wVDZnuAkTiWZnHUu4fac09lWpc4pNAwpJtBQ== X-Received: by 2002:adf:fa51:: with SMTP id y17mr21117866wrr.233.1550572415627; Tue, 19 Feb 2019 02:33:35 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id j15sm12624481wrt.1.2019.02.19.02.33.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 02:33:35 -0800 (PST) Date: Tue, 19 Feb 2019 11:24:00 +0100 From: Jiri Pirko To: Michal Kubecek Cc: netdev@vger.kernel.org, David Miller , Andrew Lunn , Jakub Kicinski , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v3 12/21] ethtool: provide permanent hardware address in GET_INFO request Message-ID: <20190219102400.GC3080@nanopsycho> References: <4e5879e36289c526dc79db37e55e5fc7d89d15fe.1550513384.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e5879e36289c526dc79db37e55e5fc7d89d15fe.1550513384.git.mkubecek@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 18, 2019 at 07:22:24PM CET, mkubecek@suse.cz wrote: >Add information about permanent hadware address of a device (as provided by >ETHTOOL_GPERMADDR ioctl command) in GET_INFO reply if ETH_INFO_IM_PERMADDR >flag is set in the request. > >There is no separate attribute for hardware address length as nla_len gives >this information. The reply also provides address type (net_device::type). > >Signed-off-by: Michal Kubecek >--- > Documentation/networking/ethtool-netlink.txt | 9 ++++- > include/uapi/linux/ethtool_netlink.h | 12 +++++- > net/ethtool/info.c | 39 ++++++++++++++++++++ > 3 files changed, 58 insertions(+), 2 deletions(-) > >diff --git a/Documentation/networking/ethtool-netlink.txt b/Documentation/networking/ethtool-netlink.txt >index b6999a2167e8..1e615e111262 100644 >--- a/Documentation/networking/ethtool-netlink.txt >+++ b/Documentation/networking/ethtool-netlink.txt >@@ -239,6 +239,9 @@ Kernel response contents: > ETHA_DRVINFO_FWVERSION (string) firmware version > ETHA_DRVINFO_BUSINFO (string) device bus address > ETHA_DRVINFO_EROM_VER (string) expansion ROM version >+ ETHA_INFO_PERMADDR (nested) >+ ETHA_PERMADDR_ADDRESS (binary) permanent HW address I think this is a nice example of thing that should not be exposed with ethtool but rather via rtnetlink, alongside with the actual hw address. [...]