From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDC3C43381 for ; Tue, 19 Feb 2019 12:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E47D2146F for ; Tue, 19 Feb 2019 12:36:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="dMr9A99D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728159AbfBSMgw (ORCPT ); Tue, 19 Feb 2019 07:36:52 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:52401 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726221AbfBSMgw (ORCPT ); Tue, 19 Feb 2019 07:36:52 -0500 Received: by mail-wm1-f67.google.com with SMTP id m1so2644735wml.2 for ; Tue, 19 Feb 2019 04:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wk1ZskZt9SLsSnbGhbNQhR7+wNdHNYlLVpLOz+Fvoro=; b=dMr9A99Di8p/NqtLMbO3KGSBa3OjMOkED5hKAlK0Mgv/jvjjYZI3ZzPKxhd8We10CR YtYtienypxSfSWo2vVyX9NFMGLs+wZFG0Q2fZEb3gWI+EmaZs5DfoMvJpBmgfEDCq7lv mSYmsjra00KmqIMslgVWpB5Q9nRadJsLEYug7uYDsWjGcA9nbGPoiOs+lpQy+dWD43No 59mgHHvE43oKwJJwUzLLeKOoNZKwTabJeVe/dzdjUnLMQ4LY9oO7+sl8I3t1BUXh8Kwz 5uDFG5fJvjGOl+r63lbGK6a67gfH0lKzZyUzeu1KCGwpnz6bgmW4NkBPS2DJDerR9Bd6 BQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wk1ZskZt9SLsSnbGhbNQhR7+wNdHNYlLVpLOz+Fvoro=; b=FRCwytAHOtCxI90okpfCQJ6v73AlRfBRpFj44rDsZ3+Ds6GZadGaTiLwrsDWSe9SA3 B4iMIcJA3fMNtgYdaWhJHwiYeIc5akhDrn2CSg+ZTZ6xVRYoiFi1UR7kM5qWmS4zDfV6 z7mvOFQO2liTNlw6XNLfx2DHxyGHNQA20w7fM5sTwMTl4ZqPjv3GprEQvfW5mpE1T4Fq K6Gjjfm58DbBKrg0Zar8c/0cPVtLeHz4P8LYQoIqkiBaLAlinAthxNgdTEueAsawMoW7 JEOjQUv9VLb1i36jwdJGdlbY0P2Xu6xGacNcuiX3u3IUUoAGKgiJPs16JZLcCC1AuXtx a8Fw== X-Gm-Message-State: AHQUAuZwPH+W+It43Xtev/JBuroOl+hC96X6Um/Ru46uWdxtC7AYUmQY LEGkE961T2jTRx/SdrGlMXqtzakfyks= X-Google-Smtp-Source: AHgI3IaR7OZf7BaSSoV4WY0i7jCDuvvjCPqvSVVss2Wzp4rUNu3+/9gKesba4SFIwAM+fcVvWtSqFA== X-Received: by 2002:a5d:68c2:: with SMTP id p2mr19196194wrw.23.1550579809761; Tue, 19 Feb 2019 04:36:49 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id h142sm3805927wme.33.2019.02.19.04.36.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 04:36:49 -0800 (PST) Date: Tue, 19 Feb 2019 13:27:14 +0100 From: Jiri Pirko To: Michal Kubecek Cc: netdev@vger.kernel.org, David Miller , Andrew Lunn , Jakub Kicinski , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v3 00/21] ethtool netlink interface, part 1 Message-ID: <20190219122714.GE3080@nanopsycho> References: <20190219103508.GD3080@nanopsycho> <20190219115727.GE23151@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219115727.GE23151@unicorn.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 19, 2019 at 12:57:27PM CET, mkubecek@suse.cz wrote: >On Tue, Feb 19, 2019 at 11:35:08AM +0100, Jiri Pirko wrote: >> >- some features provided by ethtool would rather belong to devlink (and >> > some are already superseded by devlink); however, only few drivers >> > provide devlink interface at the moment and as recent discussion on >> > flashing revealed, we cannot rely on devlink's presence >> >> Could you explain why please? > >What I mean is the problem discussed under Jakub's devlink flash >patchset: that he couldn't implement only the devlink callback in nfp >and rely on the generic fallback to devlink because it wouldn't work if >devlink is built as a module. So let's fix that. > >But I think this should be addressed. If we agree that flashing (and >other features provided by ethtool at the moment) rather belongs to >devlink (which nobody seems to oppose), we should rather try to make it >possible for drivers to provide only the devlink callback and gradually >move all in-tree drivers to doing so. (And one day, remove it from >ethtool_ops.) It doesn't seem to make much sense to have devlink as >a module in such scenario. Agreed. > >Michal