From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB0BC10F00 for ; Tue, 19 Feb 2019 18:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F9182089F for ; Tue, 19 Feb 2019 18:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ofBBAV+y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbfBSSUL (ORCPT ); Tue, 19 Feb 2019 13:20:11 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40124 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfBSSUL (ORCPT ); Tue, 19 Feb 2019 13:20:11 -0500 Received: by mail-qk1-f193.google.com with SMTP id h28so259209qkk.7 for ; Tue, 19 Feb 2019 10:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=txiErIbLD/ToK5EfV41PUhCFnTflXnkvCq7/Uj6vANw=; b=ofBBAV+yGFVbwl1wWYQwddTW1hVbDIVzT4nwbvSv4uVUcleWRq51GFkOdbAj4Qzvtz 4/j8rPb+gBXn3HD7pQ+Mm0MutKA/t/PXpS0rszt96rtl6NoP5EPrevVT8bEHQTz5pwJE bSgAL6WXL1aabB6XONUaWdUb/a8pd6cDceGSIQ5/MI68eLB8O/1y9sUHDHGCfLdOVW3o rpHkCYaELj5ThC+faFS2tvw84WBbQRMryb7czREH5WrEKfLkzTBHlHbCuJB1LbHIsmc7 jjyFm8ck2vF1wqH1YE0MPGZH85WRYl5ZJDlW/p02r0zAQP4eLGJqUM0kqBDOobcf7yQX 98cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=txiErIbLD/ToK5EfV41PUhCFnTflXnkvCq7/Uj6vANw=; b=sKJPcs/f1KTpifbKFjMdJqknyAZa8j9Ajv/MwRRVt1qh3f3Qlc1ckSOn7+rULUPAe3 IujDKLq9Tc2ZRVGAC4Q/dsbV/YlffRCxfVO5iY9BtjQv8I+dNbhlYxJ/AKyW3xhxyjxY kXgqiSHWHMICcf6RennUCoUUIx+7dGNaskhUvVdeat/XVNWqIDkVM1SVt950152o1GBz rk6VNndhIKDkOC039x/ULlf6KRZxLak2KxubEfZ/PFjP38MWEfqa1FbgAYLXU52j8nUR IIEEg3udyUxHjwhhErvDgYnuXeLc4/T2Z6yfQzUj53yc8oMM7KTzgviF4264EH7zhvWO n/8Q== X-Gm-Message-State: AHQUAuZdU+sCiJXz1aFFEYI3+kWZKvQ4diRFQP5RMxgkreqYH1HVBDp2 88EuPQL8z1O+Np468UkTuGc= X-Google-Smtp-Source: AHgI3IZ6Ms9549Yqe1ei0Nms3Sarv50aN9/P4RyxuNXq0M8hhgLPTr250c0UcTa0h1N0MkzSWXcGEg== X-Received: by 2002:ae9:c119:: with SMTP id z25mr21380906qki.222.1550600409736; Tue, 19 Feb 2019 10:20:09 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 37sm5057987qtz.95.2019.02.19.10.20.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 10:20:09 -0800 (PST) Date: Tue, 19 Feb 2019 13:20:08 -0500 Message-ID: <20190219132008.GB16594@t480s.localdomain> From: Vivien Didelot To: Florian Fainelli Cc: Russell King - ARM Linux admin , Andrew Lunn , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags In-Reply-To: References: <20190217163114.yomawlljyxlqy3ob@shell.armlinux.org.uk> <20190219111612.GF27578@t480s.localdomain> <20190219162435.f5zl5harbarwy6bj@shell.armlinux.org.uk> <20190219120000.GB4140@t480s.localdomain> <20190219171414.cvaiw7u2xnd5zk3g@shell.armlinux.org.uk> <20190219123828.GD10959@t480s.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Florian, On Tue, 19 Feb 2019 09:44:32 -0800, Florian Fainelli wrote: > > OK, thanks for the details. The programming of the broadcast MAC address > > must be handled in the core then, I will move this from mv88e6xxx up to the > > DSA layer later, but that's totally orthogonal here. > > I am not sure if it makes sense for us to work hard on supporting > BR_BCAST_FLOOD, for instance, on Broadcom switches, there does not > appear to be an easy way to specify whether broadcast traffic will be > flooded or not, it will be. The only way to tsolve that is to create a > MDB/FDB entry with negative logic (e.g.: forward to a > non-existing/connected port). Every other bridge flag typically maps 1:1 > with a corresponding hardware feature, so we should support them. I think it's best to keep away from driver-specific hacks :-) Since broadcom floods multicast and BR_BCAST_FLOOD is set by default, this would simply translate as not implementing a port_flood_bc ops in the broadcom driver. But I agree that it doesn't seem necessary to implement support for this yet. Thanks, Vivien