From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAF9C43381 for ; Tue, 19 Feb 2019 23:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C6F521736 for ; Tue, 19 Feb 2019 23:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="NmArBD7Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728427AbfBSXWm (ORCPT ); Tue, 19 Feb 2019 18:22:42 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:38452 "EHLO mail-pl1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbfBSXWl (ORCPT ); Tue, 19 Feb 2019 18:22:41 -0500 Received: by mail-pl1-f169.google.com with SMTP id e5so11178004plb.5 for ; Tue, 19 Feb 2019 15:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7GoGgPv381aDfSEAn1aIKmbW4K3pAuWBTwoFKnm2r/g=; b=NmArBD7QIYFg3Cj3Y0K2/+8WH/Pv7cEQ536Wgzkx+1ppqH0XdpgLIggJ0nKestbUbf yel2lKmG7malAbEvdzKCZajN4XYAKMqWlXjnNhoB6BYzDvafXY7ouc4RgkFbkhCwq91M grIT9qOfFp+HX2UlggvXwl7m5jFae+JtyR/BvyUhVAeeJJpoj8b863a+skkpfoPznqwv nSoANTqkHIz2XS+KXYBZbLNPW1tv5sohq5AzaAEDDijj2aIR8cjoNZM0w8BZ47QKhvwd ix0H9XnNtAxMgMx+d8kJKbg27N55cfgR144vbPoX/7VYJLf0XH0QNIx+2KN/tJTq16fN j/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GoGgPv381aDfSEAn1aIKmbW4K3pAuWBTwoFKnm2r/g=; b=pIf7Lgb8VKcs+dLEvf9QIL98cXHcGC3WZ/CsdtK2UouAWvEMJRWkHCt+6ZQDrY7wI2 M6YT3sB7uFXK8fVsnr8tfuS3igGA7KOmMu/0el2h9yJNQ5gyKo2cMXQxaz8CBQACVYNR x9VKKefICbRf+pEtaeii/mjnMR/uixFdanRh5a79+yWnOMZe2ABXn3bUjMCMaDct2iiy dUlEH5nQzi4Qqft0BuSkY0srDQK1szxEAsyzcWSlVCeowoZ1jWGfiqdBibgCAMqqEX8P 5lWUR5cnlTH1gwH6vUl4mSyhJSUlIc9tEs++ScFaRhDuq5pSJq/mqHTIgLOU3TrBL+zZ Q4Sw== X-Gm-Message-State: AHQUAuZZG+7sZda9RmMwUcoObMqHqu4nf4yZcsq2s3xIcrqguT0Kmoqo Y0Bwfd708yp40Pe2WIoLNmXu6w== X-Google-Smtp-Source: AHgI3IZT5yqSGtxd5IjWfyrgM0UVTct9IeAPBm7Y6quB1SdGw6LZ15GHSno1Y1RP5TDPmLZnu8XD2Q== X-Received: by 2002:a17:902:8f83:: with SMTP id z3mr32700674plo.328.1550618561024; Tue, 19 Feb 2019 15:22:41 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i8sm29719761pgo.19.2019.02.19.15.22.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 15:22:40 -0800 (PST) Date: Tue, 19 Feb 2019 15:22:38 -0800 From: Stephen Hemminger To: Luca Boccassi Cc: netdev@vger.kernel.org, =?UTF-8?B?Q2zDqW1lbnQ=?= Hertling Subject: Re: [RFC iproute2 v2] ip route: get: allow zero-length subnet mask Message-ID: <20190219152238.05298fc2@shemminger-XPS-13-9360> In-Reply-To: <20190214232918.6185-1-bluca@debian.org> References: <20190213200954.32271-1-bluca@debian.org> <20190214232918.6185-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 14 Feb 2019 23:29:18 +0000 Luca Boccassi wrote: > A /0 subnet mask is theoretically valid, but ip route get doesn't allow > it: >=20 > $ ip route get 1.0.0.0/0 > need at least a destination address >=20 > Change the check and remember whether we found an address or not, since > according to the documentation it's a mandatory parameter. >=20 > $ ip/ip route get 1.0.0.0/0 > 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000 > cache >=20 > Reported-by: Cl=C3=A9ment Hertling > Signed-off-by: Luca Boccassi > --- Applied