From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D7AC43381 for ; Wed, 20 Feb 2019 00:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CE8921738 for ; Wed, 20 Feb 2019 00:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="cPagibtr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730264AbfBTAGN (ORCPT ); Tue, 19 Feb 2019 19:06:13 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:50330 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730020AbfBTAFi (ORCPT ); Tue, 19 Feb 2019 19:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6jMCmueWm8nNt6zVpkKVL8LLktUO9SGuw49e3j2zmHM=; b=cPagibtrMD6m+loRGE/MOgIQZ S/aBEnY/Pcc23jsfbWJ97N+81LrV+2ZrvLI/lTn6gYCy1eMEmZsM6lNTi5diBfwnPDHRlPHXv5IqE 1VJoYJ6TgD+cTILJ7+ETMUoXShLMc5mGnuBF4y0fvFR7yyJTMM9AM6Uh2VDSdy/njkOB2ewZnWAES FWOFClfkyKExwcq+ezuAu/3CmjzCdVGZPHZPHb7XhX1AEnVGNKEctTeD8Bsp9ZksE0hm1p4esJ9pd YA7/h6kHP0BM/bnFmaFUGPGrzvY6yig89m9N5CehjSSQPz7+0I5DIE3tnBerd4OgGdZsXVkQdqeZm fiUup7FYw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:54604) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gwFOF-0000Nm-4M; Wed, 20 Feb 2019 00:05:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gwFOD-0008Ov-4r; Wed, 20 Feb 2019 00:05:29 +0000 Date: Wed, 20 Feb 2019 00:05:29 +0000 From: Russell King - ARM Linux admin To: Vivien Didelot Cc: netdev@vger.kernel.org, stephen@networkplumber.org Subject: Re: [PATCH iproute2] bridge: make mcast_flood description consistent Message-ID: <20190220000528.pl6uc2w3hcxiwb7v@shell.armlinux.org.uk> References: <20190219234738.17009-1-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219234738.17009-1-vivien.didelot@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 19, 2019 at 06:47:38PM -0500, Vivien Didelot wrote: > This patch simply changes the description of the mcast_flood flag > with "flood" instead of "be flooded with" to avoid confusion, and be > consistent with the description of the flooding flag, which "Controls > whether a given port will *flood* unicast traffic for which there is > no FDB entry." Hi Vivien, I'm not sure if it's in the current iproute2, but there is a discrepency between the arguments for 'bridge' stated in the man page and the description thereof: bridge link set dev DEV [ cost COST ] [ priority PRIO ] [ state STATE ... } ] [ learning_sync { on | off } ] [ flood { on | off } ] [ ^^^^^^^^^^^^^^^^^^ vs flooding on or flooding off Controls whether a given port will flood unicast traffic for which there is no FDB entry. By default this flag is on. vs the command actually accepting "flood" not "flooding". I spotted that in iproute2-4.20.0. I haven't had a chance to generate a patch that yet and work out how to submit it, but thanks for leading the way! > > Signed-off-by: Vivien Didelot > --- > man/man8/bridge.8 | 2 +- > man/man8/ip-link.8.in | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 > index 72210f62..03b33d34 100644 > --- a/man/man8/bridge.8 > +++ b/man/man8/bridge.8 > @@ -361,7 +361,7 @@ switch. > > .TP > .BR "mcast_flood on " or " mcast_flood off " > -Controls whether a given port will be flooded with multicast traffic for which there is no MDB entry. By default this flag is on. > +Controls whether a given port will flood multicast traffic for which there is no MDB entry. By default this flag is on. > > .TP > .BR "neigh_suppress on " or " neigh_suppress off " > diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in > index 5132f514..cef489a4 100644 > --- a/man/man8/ip-link.8.in > +++ b/man/man8/ip-link.8.in > @@ -2155,7 +2155,7 @@ queries. > option above. > > .BR mcast_flood " { " on " | " off " }" > -- controls whether a given port will be flooded with multicast traffic for which there is no MDB entry. > +- controls whether a given port will flood multicast traffic for which there is no MDB entry. > > .BI group_fwd_mask " MASK " > - set the group forward mask. This is the bitmask that is applied to decide whether to forward incoming frames destined to link-local addresses, ie addresses of the form 01:80:C2:00:00:0X (defaults to 0, ie the bridge does not forward any link-local frames coming on this port). > -- > 2.20.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up